[lib] introduce deleteFarcasterChannelTagActionTypes
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 12:47 PM.

Details

Reviewers

atul
bartek
tomek

Commits

rCOMMdd631917b6ec: [lib] introduce deleteFarcasterChannelTagActionTypes

Summary

This diff introduces the deleteFarcasterChannelTagActionTypes so that we can dispatch this action from the client and is another necessary piece we need to properly call the delete_farcaster_channel_tag endpoint

Depends on D11814

Test Plan

Locally I was able to confirm that when I dispatched this new action I would call the delete_farcaster_channel_tag endpoint

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2024, 12:47 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 12:47 PM

ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 12:48 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, bartek, tomek.

ginsu added a parent revision: D11814: [keyserver/lib] introduce delete_farcaster_channel_tag endpoint.

ginsu added a child revision: D11821: [lib] introduce useDeleteFarcasterChannelTag.Apr 26 2024, 12:58 PM

Harbormaster completed remote builds in B28538: Diff 39594.Apr 26 2024, 1:03 PM

ginsu requested review of this revision.Apr 26 2024, 1:03 PM

tomek accepted this revision.Apr 29 2024, 1:28 AM

tomek added inline comments.

lib/types/redux-types.js
1419 ↗	(On Diff #39594)	Are you sure we don't need any payload here?

This revision is now accepted and ready to land.Apr 29 2024, 1:28 AM

ginsu added inline comments.May 1 2024, 10:44 PM

lib/types/redux-types.js
1419 ↗	(On Diff #39594)	Yes, I haven't needed the `payload` in my local stack so far. If I do realize later that we actually do, I will create a follow up diff for this