Page MenuHomePhabricator
Differential D11784

[native] update selectedChannel state to be a FarcasterChannel type
ClosedPublic
Actions

Authored by ginsu on Thu, Apr 25, 1:35 PM.
Tags
None
Referenced Files
F1715802: D11784.id39674.diff
Tue, May 7, 7:46 PM
Unknown Object (File)
Mon, May 6, 9:47 PM
Unknown Object (File)
Mon, May 6, 2:29 PM
Unknown Object (File)
Sat, May 4, 5:31 PM
Unknown Object (File)
Thu, May 2, 12:08 PM
Unknown Object (File)
Thu, May 2, 10:56 AM
Unknown Object (File)
Wed, May 1, 11:09 PM
Unknown Object (File)
Wed, May 1, 3:03 PM
View All 9 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
atul
Commits
rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type
Summary

The selectedChannel state in the TagFarcasterChannel component was intially typed as a string. However, we should use the FarcasterChannel type here since I plan to use the farcaster channel id (which is a field in FarcasterChannel) in a subsequent diff

Depends on D11776

Test Plan

flow + confirmed that the existing farcaster channel selection user flow has no regressions

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Thu, Apr 25, 1:35 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 25, 1:35 PM
ginsu edited the summary of this revision. (Show Details)Thu, Apr 25, 1:38 PM
ginsu added reviewers: inka, atul.
ginsu added a parent revision: D11776: [lib] move farcaster types to dedicated file.
ginsu added a child revision: D11785: [native] introduce TagFarcasterChannelParams.Thu, Apr 25, 1:42 PM
Harbormaster completed remote builds in B28480: Diff 39510.Thu, Apr 25, 1:51 PM
ginsu requested review of this revision.Thu, Apr 25, 1:51 PM
inka accepted this revision.Fri, Apr 26, 8:30 AM
This revision is now accepted and ready to land.Fri, Apr 26, 8:30 AM
ginsu updated this revision to Diff 39667.Mon, Apr 29, 11:51 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mon, Apr 29, 11:57 AM
Closed by commit rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7cf5ed482dfa: [native] update selectedChannel state to be a FarcasterChannel type.
Harbormaster completed remote builds in B28587: Diff 39667.Mon, Apr 29, 12:13 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
22 lines

Diff 39674

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...