Page MenuHomePhabricator
Differential D11808

[keysever/lib/native] introduce gate for tagging farcaster channel work
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 10:42 AM
Unknown Object (File)
Wed, Apr 16, 3:15 AM
Unknown Object (File)
Wed, Apr 16, 2:26 AM
Unknown Object (File)
Tue, Apr 15, 10:33 PM
Unknown Object (File)
Tue, Apr 15, 6:31 PM
Unknown Object (File)
Mon, Apr 14, 6:55 PM
Unknown Object (File)
Mon, Apr 7, 6:46 AM
Unknown Object (File)
Tue, Apr 1, 9:36 AM
View All 84 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
atul
inka
ashoat
Commits
rCOMM5d8c30d8715a: [keysever/lib/native] introduce gate for tagging farcaster channel work
Summary

This gate will be used to guarantee that nobody (internally + externally) creates a Farcaster channel tag and thus has a blob holder on their client on prod.

Depends on D11772

Test Plan

Confirmed that when GATE_TAG_FARCASTER_CHANNEL is true we can't access the UI + also confirmed that the create_or_update_farcaster_channel_tag would immediatly throw an error

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2024, 11:52 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 11:52 AM
ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 11:54 AM
ginsu added reviewers: tomek, atul, inka.
ginsu added a parent revision: D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.
ginsu added a child revision: D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
ginsu mentioned this in D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.Apr 26 2024, 11:59 AM
Harbormaster completed remote builds in B28529: Diff 39583.Apr 26 2024, 12:16 PM
ginsu requested review of this revision.Apr 26 2024, 12:16 PM
ashoat accepted this revision.Apr 27 2024, 9:35 AM
ashoat added inline comments.
lib/shared/community-utils.js
3 ↗(On Diff #39583)

From the name it's unclear whether this will allow or prohibit the tagging of farcaster channels. Can you rename it to clarify? Eg. maybe DISABLE_TAGGING_FARCASTER_CHANNEL (or ENABLE_TAGGING_FARCASTER_CHANNEL, but then I guess you'd have to flip the checks)

This revision is now accepted and ready to land.Apr 27 2024, 9:35 AM
ginsu updated this revision to Diff 39662.Apr 29 2024, 11:35 AM

address comments

Harbormaster completed remote builds in B28582: Diff 39662.Apr 29 2024, 11:52 AM
Closed by commit rCOMM5d8c30d8715a: [keysever/lib/native] introduce gate for tagging farcaster channel work (authored by ginsu). · Explain WhyApr 29 2024, 11:57 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5d8c30d8715a: [keysever/lib/native] introduce gate for tagging farcaster channel work.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
5 lines
lib/
shared/
5 lines
native/
components/
2 lines

Diff 39669

View Options

keyserver/src/creators/farcaster-channel-tag-creator.js

// @flow // @flow
import uuid from 'uuid'; import uuid from 'uuid';
import { DISABLE_TAGGING_FARCASTER_CHANNEL } from 'lib/shared/community-utils.js';
import type { import type {
CreateOrUpdateFarcasterChannelTagRequest, CreateOrUpdateFarcasterChannelTagRequest,
CreateOrUpdateFarcasterChannelTagResponse, CreateOrUpdateFarcasterChannelTagResponse,
} from 'lib/types/community-types.js'; } from 'lib/types/community-types.js';
import { ServerError } from 'lib/utils/errors.js'; import { ServerError } from 'lib/utils/errors.js';
import { import {
uploadBlob, uploadBlob,
assignHolder, assignHolder,
download, download,
type BlobOperationResult, type BlobOperationResult,
type BlobDownloadResult, type BlobDownloadResult,
} from '../services/blob.js'; } from '../services/blob.js';
import { Viewer } from '../session/viewer.js'; import { Viewer } from '../session/viewer.js';
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
const { commCommunityID, farcasterChannelID } = request; const { commCommunityID, farcasterChannelID } = request;
if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
throw new ServerError('internal_error');
}
const blobDownload = await getFarcasterChannelTagBlob(farcasterChannelID); const blobDownload = await getFarcasterChannelTagBlob(farcasterChannelID);
if (blobDownload.found) { if (blobDownload.found) {
throw new ServerError('already_in_use'); throw new ServerError('already_in_use');
} }
const blobHolder = uuid.v4(); const blobHolder = uuid.v4();
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines
View Options

lib/shared/community-utils.js

  • This file was added.
// @flow
const DISABLE_TAGGING_FARCASTER_CHANNEL = true;
export { DISABLE_TAGGING_FARCASTER_CHANNEL };
View Options

native/components/community-actions-button.react.js

// @flow // @flow
import { useActionSheet } from '@expo/react-native-action-sheet'; import { useActionSheet } from '@expo/react-native-action-sheet';
import { useNavigation } from '@react-navigation/native'; import { useNavigation } from '@react-navigation/native';
import * as React from 'react'; import * as React from 'react';
import { TouchableOpacity, View } from 'react-native'; import { TouchableOpacity, View } from 'react-native';
import { useSafeAreaInsets } from 'react-native-safe-area-context'; import { useSafeAreaInsets } from 'react-native-safe-area-context';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { DISABLE_TAGGING_FARCASTER_CHANNEL } from 'lib/shared/community-utils.js';
import { useThreadHasPermission } from 'lib/shared/thread-utils.js'; import { useThreadHasPermission } from 'lib/shared/thread-utils.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypes } from 'lib/types/thread-types-enum.js'; import { threadTypes } from 'lib/types/thread-types-enum.js';
import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js'; import { useCurrentUserFID } from 'lib/utils/farcaster-utils.js';
import { usingCommServicesAccessToken } from 'lib/utils/services-utils.js'; import { usingCommServicesAccessToken } from 'lib/utils/services-utils.js';
import SWMansionIcon from './swmansion-icon.react.js'; import SWMansionIcon from './swmansion-icon.react.js';
▲ Show 20 Lines • Show All 97 Lines • ▼ Show 20 Lines const actions = React.useMemo(() => {
if (canChangeRoles) { if (canChangeRoles) {
result.push({ result.push({
label: 'Manage roles', label: 'Manage roles',
action: navigateToCommunityRolesScreen, action: navigateToCommunityRolesScreen,
}); });
} }
const canTagFarcasterChannel = const canTagFarcasterChannel =
!DISABLE_TAGGING_FARCASTER_CHANNEL &&
fid && fid &&
community.type !== threadTypes.GENESIS && community.type !== threadTypes.GENESIS &&
(usingCommServicesAccessToken || __DEV__); (usingCommServicesAccessToken || __DEV__);
if (canTagFarcasterChannel) { if (canTagFarcasterChannel) {
result.push({ result.push({
label: 'Tag Farcaster channel', label: 'Tag Farcaster channel',
action: navigateToTagFarcasterChannel, action: navigateToTagFarcasterChannel,
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines