native] introduce gate for tagging farcaster channel work
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 11:52 AM.

Details

Reviewers

tomek
atul
inka
ashoat

Commits

rCOMM5d8c30d8715a: [keysever/lib/native] introduce gate for tagging farcaster channel work

Summary

This gate will be used to guarantee that nobody (internally + externally) creates a Farcaster channel tag and thus has a blob holder on their client on prod.

Depends on D11772

Test Plan

Confirmed that when GATE_TAG_FARCASTER_CHANNEL is true we can't access the UI + also confirmed that the create_or_update_farcaster_channel_tag would immediatly throw an error

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 26 2024, 11:52 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 11:52 AM

ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 11:54 AM

ginsu added reviewers: tomek, atul, inka.

ginsu added a parent revision: D11772: [keyserver] introduce barebones createOrUpdateFarcasterChannelTag.

ginsu added a child revision: D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.

ginsu mentioned this in D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.Apr 26 2024, 11:59 AM

Harbormaster completed remote builds in B28529: Diff 39583.Apr 26 2024, 12:16 PM

ginsu requested review of this revision.Apr 26 2024, 12:16 PM

ashoat accepted this revision.Apr 27 2024, 9:35 AM

ashoat added inline comments.

lib/shared/community-utils.js
3 ↗	(On Diff #39583)	From the name it's unclear whether this will allow or prohibit the tagging of farcaster channels. Can you rename it to clarify? Eg. maybe `DISABLE_TAGGING_FARCASTER_CHANNEL` (or `ENABLE_TAGGING_FARCASTER_CHANNEL`, but then I guess you'd have to flip the checks)