Page MenuHomePhabricator
Differential D11809

[native] show error message for tag farcaster channel errors
ClosedPublic
Actions

Authored by ginsu on Apr 26 2024, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 5:05 PM
Unknown Object (File)
Wed, Apr 16, 11:04 AM
Unknown Object (File)
Wed, Apr 16, 8:10 AM
Unknown Object (File)
Tue, Apr 15, 8:11 PM
Unknown Object (File)
Tue, Apr 15, 12:48 PM
Unknown Object (File)
Wed, Apr 9, 11:40 AM
Unknown Object (File)
Tue, Apr 1, 12:17 PM
Unknown Object (File)
Mar 11 2025, 12:47 PM
View All 85 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors
Summary

This diff improves the error handling for creating a farcaster tag blob. If there is an error we will display a message to the user for why the request failed

Depends on D11793

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 26 2024, 12:03 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 26 2024, 12:03 PM
ginsu edited the summary of this revision. (Show Details)Apr 26 2024, 12:11 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11793: [native] introduce tag farcaster button.
ginsu attached a referenced file: F1667388: Screen Recording 2024-04-26 at 3.10.36 PM.mov. (Show Details)
ginsu added a reviewer: ashoat.

This diff introduces new copy

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
26 ↗(On Diff #39586)

This copy needs to be reviewed

164 ↗(On Diff #39586)

Copy needs to be reviewed

ginsu mentioned this in D11793: [native] introduce tag farcaster button.Apr 26 2024, 12:13 PM
Harbormaster completed remote builds in B28531: Diff 39586.Apr 26 2024, 12:27 PM
ginsu requested review of this revision.Apr 26 2024, 12:27 PM
ginsu added a child revision: D11813: [keyserver] introduce deleteFarcasterChannelTag.Apr 26 2024, 12:34 PM
ashoat resigned from this revision.Apr 27 2024, 4:55 PM

Copy looks okay. Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time

inka accepted this revision.Apr 30 2024, 8:58 AM
inka added inline comments.
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
94 ↗(On Diff #39586)

Can we move this to onOptionSelected? If you disagree I won't insist, but it seems more natural to me that the error would disappear only once a different item is picked

This revision is now accepted and ready to land.Apr 30 2024, 8:58 AM
ginsu updated this revision to Diff 39698.Apr 30 2024, 9:16 AM

address comments + rebase before landing

ginsu added a comment.Apr 30 2024, 9:21 AM

Thought about whether we could filter the list of channels before it gets to the keyserver, but we'd probably need a UI to show which ones are already taken, in addition to logic on the client to check each channel with the blob service. Probably too much additional complexity to be worth doing at this time

Agree this would be nice to have, but also agree that this should be considered out of scope for now. I created a linear task to track this piece of feedback:

https://linear.app/comm/issue/ENG-8032/filter-list-of-taken-farcaster-channels

This revision was landed with ongoing or failed builds.Apr 30 2024, 9:23 AM
Closed by commit rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM57c01e17a94d: [native] show error message for tag farcaster channel errors.
Harbormaster completed remote builds in B28604: Diff 39698.Apr 30 2024, 9:33 AM
ginsu mentioned this in D11893: [native] improve error handling for TagUnfollowedFarcasterChannel screen.May 6 2024, 12:17 AM
ginsu mentioned this in D12041: [native] display existing farcaster channel tag in TagFarcasterChannel screen.May 15 2024, 7:03 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
34 lines

Diff 39698

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Show All 13 Lines
} }
jsi::Value CommRustModule::generateNonce(jsi::Runtime &rt) { jsi::Value CommRustModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGenerateNonce(currentID); identityGenerateNonce(currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
Show All 25 Linesjsi::Value CommRustModule::registerUser(
auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt); auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt);
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityRegisterUser( identityRegisterUser(
usernameRust, usernameRust,
passwordRust, passwordRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 36 Linesjsi::Value CommRustModule::loginPasswordUser(
auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt); auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt);
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityLoginPasswordUser( identityLoginPasswordUser(
usernameRust, usernameRust,
passwordRust, passwordRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 38 Linesjsi::Value CommRustModule::loginWalletUser(
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
auto socialProofRust = jsiStringToRustString(socialProof, rt); auto socialProofRust = jsiStringToRustString(socialProof, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityLoginWalletUser( identityLoginWalletUser(
siweMessageRust, siweMessageRust,
siweSignatureRust, siweSignatureRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 23 Linesjsi::Value CommRustModule::updatePassword(
auto accessTokenRust = jsiStringToRustString(accessToken, rt); auto accessTokenRust = jsiStringToRustString(accessToken, rt);
auto passwordRust = jsiStringToRustString(password, rt); auto passwordRust = jsiStringToRustString(password, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityUpdateUserPassword( identityUpdateUserPassword(
userIDRust, userIDRust,
deviceIDRust, deviceIDRust,
accessTokenRust, accessTokenRust,
passwordRust, passwordRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 14 Linesjsi::Value CommRustModule::deleteUser(
auto deviceIDRust = jsiStringToRustString(deviceID, rt); auto deviceIDRust = jsiStringToRustString(deviceID, rt);
auto accessTokenRust = jsiStringToRustString(accessToken, rt); auto accessTokenRust = jsiStringToRustString(accessToken, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityDeleteUser( identityDeleteUser(
userIDRust, deviceIDRust, accessTokenRust, currentID); userIDRust, deviceIDRust, accessTokenRust, currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
Show All 12 Linesjsi::Value CommRustModule::getOutboundKeysForUser(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto userIDRust = jsiStringToRustString(userID, rt); auto userIDRust = jsiStringToRustString(userID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetOutboundKeysForUser( identityGetOutboundKeysForUser(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
userIDRust, userIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 16 Linesjsi::Value CommRustModule::getInboundKeysForUser(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto userIDRust = jsiStringToRustString(userID, rt); auto userIDRust = jsiStringToRustString(userID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetInboundKeysForUser( identityGetInboundKeysForUser(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
userIDRust, userIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityVersionSupported(currentID); identityVersionSupported(currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
Show All 15 Linesjsi::Value CommRustModule::uploadOneTimeKeys(
auto notifOneTimePreKeysRust = auto notifOneTimePreKeysRust =
jsiStringArrayToRustVec(notifOneTimePreKeys, rt); jsiStringArrayToRustVec(notifOneTimePreKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityUploadOneTimeKeys( identityUploadOneTimeKeys(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
contentOneTimePreKeysRust, contentOneTimePreKeysRust,
notifOneTimePreKeysRust, notifOneTimePreKeysRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
Show All 17 Linesjsi::Value CommRustModule::getKeyserverKeys(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto keyserverIDRust = jsiStringToRustString(keyserverID, rt); auto keyserverIDRust = jsiStringToRustString(keyserverID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetKeyserverKeys( identityGetKeyserverKeys(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
keyserverIDRust, keyserverIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 9 Lines