Paths

Table of Contentst

-
lib/utils/
-
utils/
1/2
neynar-client.js

[lib] introduce fetchFarcasterChannelByName to neynar client class
ClosedPublic
Actions

Authored by ginsu on May 3 2024, 12:38 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMM62e742612659: [lib] introduce fetchFarcasterChannelByName to neynar client class

Summary

fetchFarcasterChannelByName is a function that given a farcaster channel name, will retreive the info for that channel. The reason for this function is that we want to validate the user input given to us from the TagUnfollowedFarcasterChannel screen and confirm that the user inputted a valid channel name.

If the user inputted a channel name that does not exist, fetchFarcasterChannelByName will return null

Neynar API docs: https://docs.neynar.com/reference/search-channels

Linear task: https://linear.app/comm/issue/ENG-7471/add-the-search-channels-neynar-endpoint-to-our-neynar-api-client

Test Plan

Used the neynar docs to confirm that fetchFarcasterChannelByName was getting the expected/same response as the docs.

Additionally confirmed that fetchFarcasterChannelByName when I inputted a channel name that does not exist on farcaster

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 3 2024, 12:38 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 3 2024, 12:38 AM

ginsu edited the summary of this revision. (Show Details)May 3 2024, 12:41 AM

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)May 3 2024, 12:47 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 3 2024, 12:48 AM

Harbormaster failed remote builds in B28640: Diff 39758!

will make sure ci passes before landing

ginsu added a child revision: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.May 3 2024, 12:51 AM

ashoat accepted this revision.May 4 2024, 11:03 AM

ashoat added inline comments.

lib/utils/neynar-client.js
28 ↗	(On Diff #39758)	Surprised there are no other properties here… sure we don’t need a `…`?
155 ↗	(On Diff #39758)	Is Neynar’s API case-insensitive? Wondering since you have `toLowerCase` below

This revision is now accepted and ready to land.May 4 2024, 11:03 AM

ginsu added inline comments.May 5 2024, 5:43 PM

lib/utils/neynar-client.js

28 ↗

(On Diff #39758)

The response only has channels. Here is an example:

{
  "channels": [
    {
      "id": "neynar",
      "url": "chain://eip155:1/erc721:0xd4498134211baad5846ce70ce04e7c4da78931cc",
      "name": "Neynar",
      "description": "The easiest way to build on Farcaster | neynar.com | @neynar",
      "follower_count": 7680,
      "object": "channel",
      "image_url": "https://i.imgur.com/j9CEVlk.png",
      "created_at": 1690488765,
      "parent_url": "chain://eip155:1/erc721:0xd4498134211baad5846ce70ce04e7c4da78931cc",
      "lead": {
        "object": "user",
        "fid": 194,
        "custody_address": "0xb95dc10483be18f7c69ddf78d4baafecc01c5530",
        "username": "rish",
        "display_name": "rish",
        "pfp_url": "https://i.imgur.com/naZWL9n.gif",
        "profile": {
          "bio": {
            "text": "building /neynar 🪐 | neynar.com | /rish "
          }
        },
        "follower_count": 110419,
        "following_count": 665,
        "verifications": [
          "0x5a927ac639636e534b678e81768ca19e2c6280b7",
          "0xe9e261852ea62150eee685807df8fe3f211310a0"
        ],
        "verified_addresses": {
          "eth_addresses": [
            "0x5a927ac639636e534b678e81768ca19e2c6280b7",
            "0xe9e261852ea62150eee685807df8fe3f211310a0"
          ],
          "sol_addresses": []
        },
        "active_status": "inactive",
        "power_badge": true,
        "notes": {
          "active_status": "Warpcast has transitioned from active badges to power badges, Neynar will deprecate this key in the user object in the next few weeks"
        }
      },
      "hosts": [
        {
          "object": "user",
          "fid": 194,
          "custody_address": "0xb95dc10483be18f7c69ddf78d4baafecc01c5530",
          "username": "rish",
          "display_name": "rish",
          "pfp_url": "https://i.imgur.com/naZWL9n.gif",
          "profile": {
            "bio": {
              "text": "building /neynar 🪐 | neynar.com | /rish "
            }
          },
          "follower_count": 110419,
          "following_count": 665,
          "verifications": [
            "0x5a927ac639636e534b678e81768ca19e2c6280b7",
            "0xe9e261852ea62150eee685807df8fe3f211310a0"
          ],
          "verified_addresses": {
            "eth_addresses": [
              "0x5a927ac639636e534b678e81768ca19e2c6280b7",
              "0xe9e261852ea62150eee685807df8fe3f211310a0"
            ],
            "sol_addresses": []
          },
          "active_status": "inactive",
          "power_badge": true,
          "notes": {
            "active_status": "Warpcast has transitioned from active badges to power badges, Neynar will deprecate this key in the user object in the next few weeks"
          }
        },
        {
          "object": "user",
          "fid": 191,
          "custody_address": "0x3a6dd569de84c91828fc42dce20f5b827e0ef5c5",
          "username": "manan",
          "display_name": "Manan ",
          "pfp_url": "https://i.imgur.com/nW6pvvm.jpg",
          "profile": {
            "bio": {
              "text": "🪐 Building @neynar, join us in /neynar | ex-Coinbase | manan19.twitter"
            }
          },
          "follower_count": 108602,
          "following_count": 376,
          "verifications": [
            "0x7cac817861e5c3384753403fb6c0c556c204b1ce"
          ],
          "verified_addresses": {
            "eth_addresses": [
              "0x7cac817861e5c3384753403fb6c0c556c204b1ce"
            ],
            "sol_addresses": [
              "GyBd7Ukpd3LJnjDkBG8wioRaCKQFURfDhLRnSc6EgrPi"
            ]
          },
          "active_status": "inactive",
          "power_badge": true,
          "notes": {
            "active_status": "Warpcast has transitioned from active badges to power badges, Neynar will deprecate this key in the user object in the next few weeks"
          }
        },
        {
          "object": "user",
          "fid": 6131,
          "custody_address": "0xa6a8736f18f383f1cc2d938576933e5ea7df01a1",
          "username": "neynar",
          "display_name": "Neynar",
          "pfp_url": "https://i.imgur.com/UjBZ3pV.png",
          "profile": {
            "bio": {
              "text": "best farcaster developers build on neynar.com | /neynar"
            }
          },
          "follower_count": 3876,
          "following_count": 47,
          "verifications": [
            "0xa6a8736f18f383f1cc2d938576933e5ea7df01a1"
          ],
          "verified_addresses": {
            "eth_addresses": [
              "0xa6a8736f18f383f1cc2d938576933e5ea7df01a1"
            ],
            "sol_addresses": []
          },
          "active_status": "inactive",
          "power_badge": true,
          "notes": {
            "active_status": "Warpcast has transitioned from active badges to power badges, Neynar will deprecate this key in the user object in the next few weeks"
          }
        }
      ]
    }
  ]
}

155 ↗

(On Diff #39758)

Yes confirmed that Neynar's API is case-insensitive

Screenshot 2024-05-05 at 8.31.03 PM.png (868×2 px, 241 KB)

Removing this diff from the diff stack so that I can land as is.

ginsu edited the summary of this revision. (Show Details)May 5 2024, 5:45 PM

ginsu removed a child revision: D11866: [native] implement onPressTagChannel for TagUnfollowedFarcasterChannel.

ginsu removed a parent revision: D11857: [native] implement UI for TagUnfollowedFarcasterChannel screen.

rebase before landing

Harbormaster completed remote builds in B28676: Diff 39807.May 5 2024, 6:05 PM

Closed by commit rCOMM62e742612659: [lib] introduce fetchFarcasterChannelByName to neynar client class (authored by ginsu). · Explain WhyMay 5 2024, 6:11 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM62e742612659: [lib] introduce fetchFarcasterChannelByName to neynar client class.

ginsu mentioned this in D11876: [lib] Introduce NeynarClient.getFarcasterUsernames and FCCache.May 5 2024, 6:12 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

neynar-client.js

42 lines

Diff 39807

View Options

lib/utils/neynar-client.js

Show First 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
};		};
type Props = {		type Props = {
...BaseProps,		...BaseProps,
// Redux state		// Redux state
+dimensions: DerivedDimensionsInfo,		+dimensions: DerivedDimensionsInfo,
// withOverlayContext		// withOverlayContext
+overlayContext: ?OverlayContextType,		+overlayContext: ?OverlayContextType,
+isActive: boolean,		+isActive: boolean,
};
type State = {
+closeButtonEnabled: boolean,		+closeButtonEnabled: boolean,
+actionLinksEnabled: boolean,		+actionLinksEnabled: boolean,
};		+updateCloseButtonEnabled: ([number]) => void,
class FullScreenViewModal extends React.PureComponent<Props, State> {		+updateActionLinksEnabled: ([number]) => void,
state: State = {
closeButtonEnabled: true,
actionLinksEnabled: true,
};		};

		class FullScreenViewModal extends React.PureComponent<Props> {
closeButton: ?React.ElementRef<TouchableOpacityInstance>;		closeButton: ?React.ElementRef<TouchableOpacityInstance>;
mediaIconsContainer: ?React.ElementRef<typeof View>;		mediaIconsContainer: ?React.ElementRef<typeof View>;
closeButtonX: Value = new Value(-1);		closeButtonX: Value = new Value(-1);
closeButtonY: Value = new Value(-1);		closeButtonY: Value = new Value(-1);
closeButtonWidth: Value = new Value(0);		closeButtonWidth: Value = new Value(0);
closeButtonHeight: Value = new Value(0);		closeButtonHeight: Value = new Value(0);
closeButtonLastState: Value = new Value(1);		closeButtonLastState: Value = new Value(1);
mediaIconsX: Value = new Value(-1);		mediaIconsX: Value = new Value(-1);
▲ Show 20 Lines • Show All 472 Lines • ▼ Show 20 Lines	return block([
],		],
),		),
),		),
set(this.actionLinksLastState, actionLinksState),		set(this.actionLinksLastState, actionLinksState),
set(this.closeButtonLastState, closeButtonState),		set(this.closeButtonLastState, closeButtonState),
set(wasZoomed, isZoomed),		set(wasZoomed, isZoomed),
set(lastTapX, singleTapX),		set(lastTapX, singleTapX),
set(lastTapY, singleTapY),		set(lastTapY, singleTapY),
call([eq(curCloseButtonOpacity, 1)], this.setCloseButtonEnabled),		call([eq(curCloseButtonOpacity, 1)], this.props.updateCloseButtonEnabled),
call([eq(curActionLinksOpacity, 1)], this.setActionLinksEnabled),		call([eq(curActionLinksOpacity, 1)], this.props.updateActionLinksEnabled),
]);		]);
}		}

doubleTapUpdate(		doubleTapUpdate(
// Inputs		// Inputs
doubleTapState: Node,		doubleTapState: Node,
doubleTapX: Node,		doubleTapX: Node,
doubleTapY: Node,		doubleTapY: Node,
▲ Show 20 Lines • Show All 316 Lines • ▼ Show 20 Lines	const mediaIconsButtonStyle = {
opacity: this.actionLinksOpacity,		opacity: this.actionLinksOpacity,
};		};

let saveButton;		let saveButton;
if (saveContentCallback) {		if (saveContentCallback) {
saveButton = (		saveButton = (
<TouchableOpacity		<TouchableOpacity
onPress={saveContentCallback}		onPress={saveContentCallback}
disabled={!this.state.actionLinksEnabled}		disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons}		style={styles.mediaIconButtons}
>		>
<SWMansionIcon name="save" style={styles.mediaIcon} />		<SWMansionIcon name="save" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Save</Text>		<Text style={styles.mediaIconText}>Save</Text>
</TouchableOpacity>		</TouchableOpacity>
);		);
}		}

let copyButton;		let copyButton;
if (Platform.OS === 'ios' && copyContentCallback) {		if (Platform.OS === 'ios' && copyContentCallback) {
copyButton = (		copyButton = (
<TouchableOpacity		<TouchableOpacity
onPress={copyContentCallback}		onPress={copyContentCallback}
disabled={!this.state.actionLinksEnabled}		disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons}		style={styles.mediaIconButtons}
>		>
<SWMansionIcon name="copy" style={styles.mediaIcon} />		<SWMansionIcon name="copy" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Copy</Text>		<Text style={styles.mediaIconText}>Copy</Text>
</TouchableOpacity>		</TouchableOpacity>
);		);
}		}

Show All 26 Lines	const view = (
</View>		</View>
<SafeAreaView style={styles.buttonsOverlay}>		<SafeAreaView style={styles.buttonsOverlay}>
<View style={styles.fill}>		<View style={styles.fill}>
<Animated.View		<Animated.View
style={[styles.closeButtonContainer, closeButtonStyle]}		style={[styles.closeButtonContainer, closeButtonStyle]}
>		>
<TouchableOpacity		<TouchableOpacity
onPress={this.close}		onPress={this.close}
disabled={!this.state.closeButtonEnabled}		disabled={!this.props.closeButtonEnabled}
onLayout={this.onCloseButtonLayout}		onLayout={this.onCloseButtonLayout}
ref={this.closeButtonRef}		ref={this.closeButtonRef}
>		>
<Text style={styles.closeButton}>×</Text>		<Text style={styles.closeButton}>×</Text>
</TouchableOpacity>		</TouchableOpacity>
</Animated.View>		</Animated.View>
{mediaActionButtons}		{mediaActionButtons}
</View>		</View>
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines	return (
</PinchGestureHandler>		</PinchGestureHandler>
);		);
}		}

close = () => {		close = () => {
this.props.navigation.goBackOnce();		this.props.navigation.goBackOnce();
};		};

setCloseButtonEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.closeButtonEnabled !== enabled) {
this.setState({ closeButtonEnabled: enabled });
}
};

setActionLinksEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.actionLinksEnabled !== enabled) {
this.setState({ actionLinksEnabled: enabled });
}
};

closeButtonRef = (		closeButtonRef = (
closeButton: ?React.ElementRef<typeof TouchableOpacity>,		closeButton: ?React.ElementRef<typeof TouchableOpacity>,
) => {		) => {
this.closeButton = (closeButton: any);		this.closeButton = (closeButton: any);
};		};

mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => {		mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => {
this.mediaIconsContainer = mediaIconsContainer;		this.mediaIconsContainer = mediaIconsContainer;
▲ Show 20 Lines • Show All 116 Lines • ▼ Show 20 Lines	) {
}, [isActive]);		}, [isActive]);

React.useEffect(() => {		React.useEffect(() => {
return () => {		return () => {
Orientation.lockToPortrait();		Orientation.lockToPortrait();
};		};
}, []);		}, []);

		const [closeButtonEnabled, setCloseButtonEnabled] = React.useState(true);
		const [actionLinksEnabled, setActionLinksEnabled] = React.useState(true);

		const updateCloseButtonEnabled = React.useCallback(
		([enabledNum]: [number]) => {
		tomekUnsubmitted Not Done Inline Actions We should prefer `Array` type tomek: We should prefer `Array` type
		angelikaAuthorUnsubmitted Done Inline Actions This was just copied from the original code and the `[number]` argument will be replaced with `number` argument in https://phab.comm.dev/D14304 anyway angelika: This was just copied from the original code and the `[number]` argument will be replaced with…
		const enabled = !!enabledNum;
		if (closeButtonEnabled !== enabled) {
		setCloseButtonEnabled(enabled);
		}
		},
		[closeButtonEnabled],
		);

		const updateActionLinksEnabled = React.useCallback(
		([enabledNum]: [number]) => {
		const enabled = !!enabledNum;
		if (actionLinksEnabled !== enabled) {
		setActionLinksEnabled(enabled);
		}
		},
		[actionLinksEnabled],
		);

return (		return (
<FullScreenViewModal		<FullScreenViewModal
{...props}		{...props}
dimensions={dimensions}		dimensions={dimensions}
overlayContext={overlayContext}		overlayContext={overlayContext}
isActive={isActive}		isActive={isActive}
		closeButtonEnabled={closeButtonEnabled}
		actionLinksEnabled={actionLinksEnabled}
		updateCloseButtonEnabled={updateCloseButtonEnabled}
		updateActionLinksEnabled={updateActionLinksEnabled}
/>		/>
);		);
});		});

export default ConnectedFullScreenViewModal;		export default ConnectedFullScreenViewModal;

[lib] introduce fetchFarcasterChannelByName to neynar client classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39807

lib/utils/neynar-client.js

[lib] introduce fetchFarcasterChannelByName to neynar client class
ClosedPublic
Actions

Revision Contents
Changeset List