in our identity login actions, we should check the exception message and if it tells us that the username is reserved, we should attempt reserved registration (if possible, i.e. if on native)
Depends on D11911
Details
Details
on staging, i set the keyserver public key env var to my local keyserver's device ID. then i registered a user directly with my keyserver. flipped usingCSAT to true and tried logging in again. confirmed that i was registered with the identity service and granted an access token
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/actions/user-actions.js | ||
|---|---|---|
| 661–673 ↗ | (On Diff #39858) | not sure why, but flow wasn't able to see that identityClient.registerReservedPasswordUser is not undefined inside this condition, so i used the registerReservedPasswordUser function, which calls identityClient.registerReservedPasswordUser. would like to avoid this indirection if there's a better way to resolve the flow issue |
| lib/actions/user-actions.js | ||
|---|---|---|
| 661–673 ↗ | (On Diff #39858) | I think you can avoid it if you extract registerReservedPasswordUser to a local varible before checking it |
| lib/actions/user-actions.js | ||
|---|---|---|
| 636–637 ↗ | (On Diff #40813) | Shorthand |
| 636–655 ↗ | (On Diff #40813) | You should exit early and reduce indentation |