Details
Details
Tested that before this diff, if creating the olm session failed (olmSessionPromise threw), then the user would still get registered and get a user cookie.
Checked that after this diff, if olmNotifSession throws, the user is not created in the db and they don't get a userm cookie
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
keyserver/src/creators/account-creator.js | ||
---|---|---|
103 ↗ | (On Diff #39877) | I've noticed this pattern in several places, where people seem to all-caps "Olm". I don't understand why... the makers spell it as "Olm", and it is not an acronym or initialism. Can you stick with "Olm" please? (If this was copied from somewhere, please update that place as well.) |