Page MenuHomePhabricator

[keyserver] Move accepting policies on siwe registration
ClosedPublic

Authored by inka on Tue, May 7, 3:15 AM.
Tags
None
Referenced Files
F1789465: D11918.id39878.diff
Sun, May 19, 3:27 AM
F1785015: D11918.id39916.diff
Sat, May 18, 12:48 PM
Unknown Object (File)
Fri, May 17, 7:25 AM
Unknown Object (File)
Mon, May 13, 1:22 PM
Unknown Object (File)
Mon, May 13, 11:03 AM
Unknown Object (File)
Sun, May 12, 6:50 AM
Unknown Object (File)
Sat, May 11, 12:21 PM
Unknown Object (File)
Tue, May 7, 4:44 AM
Subscribers
None

Details

Summary

issue: ENG-8047
We want to use the new way, introduced in D11780: accept the policies inside processSuccessfulLogin by setting the shouldMarkPoliciesAsAcceptedAfterCookieCreation flag

Test Plan

Tested that when a new user registeres, they don't see the policies modal - the policies were correctly accepted
Tested that if I only remove the call to viewerAcknowledgmentUpdater from processSIWEAccountCreation, but don't set the flag, then the new user does see the policies modal.
Tested that if I set policies as not accepeter for a user and login, they see the modal

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable