Page MenuHomePhabricator

[keyserver] Move accepting policies on siwe registration
ClosedPublic

Authored by inka on May 7 2024, 3:15 AM.
Tags
None
Referenced Files
F3183037: D11918.id39916.diff
Fri, Nov 8, 8:23 AM
F3178768: D11918.id39878.diff
Fri, Nov 8, 2:16 AM
Unknown Object (File)
Sun, Nov 3, 1:28 PM
Unknown Object (File)
Fri, Nov 1, 4:32 PM
Unknown Object (File)
Sat, Oct 26, 10:03 PM
Unknown Object (File)
Fri, Oct 25, 4:07 AM
Unknown Object (File)
Thu, Oct 24, 2:08 AM
Unknown Object (File)
Tue, Oct 22, 4:12 PM
Subscribers
None

Details

Summary

issue: ENG-8047
We want to use the new way, introduced in D11780: accept the policies inside processSuccessfulLogin by setting the shouldMarkPoliciesAsAcceptedAfterCookieCreation flag

Test Plan

Tested that when a new user registeres, they don't see the policies modal - the policies were correctly accepted
Tested that if I only remove the call to viewerAcknowledgmentUpdater from processSIWEAccountCreation, but don't set the flag, then the new user does see the policies modal.
Tested that if I set policies as not accepeter for a user and login, they see the modal

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable