Page MenuHomePhabricator

[keyserver] Move accepting policies on siwe registration
ClosedPublic

Authored by inka on May 7 2024, 3:15 AM.
Tags
None
Referenced Files
F3396462: D11918.diff
Sun, Dec 1, 12:32 PM
Unknown Object (File)
Thu, Nov 28, 10:05 PM
Unknown Object (File)
Thu, Nov 28, 10:08 AM
Unknown Object (File)
Sun, Nov 24, 3:34 PM
Unknown Object (File)
Sun, Nov 24, 2:46 PM
Unknown Object (File)
Sun, Nov 24, 2:46 AM
Unknown Object (File)
Thu, Nov 14, 10:48 AM
Unknown Object (File)
Thu, Nov 14, 4:57 AM
Subscribers
None

Details

Summary

issue: ENG-8047
We want to use the new way, introduced in D11780: accept the policies inside processSuccessfulLogin by setting the shouldMarkPoliciesAsAcceptedAfterCookieCreation flag

Test Plan

Tested that when a new user registeres, they don't see the policies modal - the policies were correctly accepted
Tested that if I only remove the call to viewerAcknowledgmentUpdater from processSIWEAccountCreation, but don't set the flag, then the new user does see the policies modal.
Tested that if I set policies as not accepeter for a user and login, they see the modal

Diff Detail

Repository
rCOMM Comm
Branch
inka/may2
Lint
No Lint Coverage
Unit
No Test Coverage