Page MenuHomePhabricator

[keyserver] Move accepting policies on siwe registration
ClosedPublic

Authored by inka on May 7 2024, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 2:58 PM
Unknown Object (File)
Mar 8 2025, 2:35 PM
Unknown Object (File)
Mar 8 2025, 2:35 PM
Unknown Object (File)
Mar 8 2025, 2:35 PM
Unknown Object (File)
Mar 8 2025, 2:35 PM
Unknown Object (File)
Jan 19 2025, 7:03 PM
Unknown Object (File)
Jan 19 2025, 11:15 AM
Unknown Object (File)
Jan 10 2025, 5:56 AM
Subscribers
None

Details

Summary

issue: ENG-8047
We want to use the new way, introduced in D11780: accept the policies inside processSuccessfulLogin by setting the shouldMarkPoliciesAsAcceptedAfterCookieCreation flag

Test Plan

Tested that when a new user registeres, they don't see the policies modal - the policies were correctly accepted
Tested that if I only remove the call to viewerAcknowledgmentUpdater from processSIWEAccountCreation, but don't set the flag, then the new user does see the policies modal.
Tested that if I set policies as not accepeter for a user and login, they see the modal

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable