Page MenuHomePhabricator

[lib] Don't compare identity/keyserver login when not using CSAT
ClosedPublic

Authored by ashoat on May 7 2024, 10:58 AM.
Tags
None
Referenced Files
F3182125: D11927.diff
Fri, Nov 8, 7:32 AM
F3175446: D11927.diff
Thu, Nov 7, 8:08 PM
Unknown Object (File)
Wed, Oct 23, 9:29 PM
Unknown Object (File)
Wed, Oct 23, 9:18 PM
Unknown Object (File)
Wed, Oct 23, 5:57 PM
Unknown Object (File)
Wed, Oct 23, 4:47 PM
Unknown Object (File)
Wed, Oct 23, 4:46 PM
Unknown Object (File)
Mon, Oct 21, 5:12 PM
Subscribers
None

Details

Summary

In D11692, I moved some logic from being processed on keyserverAuthActionTypes to setNewSessionActionType. I failed to consider that the former action is only used with usingCommServicesAccessToken, but the latter is used regardless of usingCommServicesAccessToken.

This prevents SET_NEW_SESSION for updating the session for legacy keyserver-based login. The session still gets updated later by the auth action (either legacy login or legacy registration), but it would be better to leave the logic as it was before, to avoid potentially breaking anything.

Test Plan
  • Make sure login and registration in legacy single-keyserver environment still works
  • Try both new and old registration flows
  • Make sure keyserver auth returned a different user info than identity login log does not appear

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixregister
Lint
No Lint Coverage
Unit
No Test Coverage