Page MenuHomePhabricator

[web] Make find user identities available to client
AbandonedPublicDraft

Authored by will on May 8 2024, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 2:28 AM
Unknown Object (File)
Thu, Nov 21, 2:28 AM
Unknown Object (File)
Thu, Nov 21, 2:28 AM
Unknown Object (File)
Sat, Nov 9, 5:39 PM
Unknown Object (File)
Oct 25 2024, 8:22 PM
Unknown Object (File)
Oct 22 2024, 1:17 PM
Unknown Object (File)
Oct 22 2024, 9:19 AM
Unknown Object (File)
Sep 15 2024, 1:38 PM
Subscribers

Details

Reviewers
kamil
bartek
Summary

This provides access to the find user identities rpc on the clients

Depends on D11952

Test Plan

In progress. Will not land until I've tested on native that the rpc can successfully be called and returns Identity object

Diff Detail

Repository
rCOMM Comm
Branch
farcaster/set_aux_user_fids
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

lib/types/identity-service-types.js
236–245

Appended an Object suffix to these names to match the protobuf code they are being set to :

export type IdentityObject = {
  username: string,
  ethIdentity: ?EthereumIdentityObject,
  farcasterId: ?string,
}

Unsure if we should drop the suffix and call these EthereumIdentity and Identity as they will have the same exact fields as their protobuf counterparts

Harbormaster returned this revision to the author for changes because remote builds failed.May 8 2024, 11:03 PM
Harbormaster failed remote builds in B28774: Diff 39961!