Page MenuHomePhabricator
Differential D11973

[native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow
ClosedPublic
Actions

Authored by ashoat on May 9 2024, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 8:54 AM
Unknown Object (File)
Sun, Nov 3, 3:15 AM
Unknown Object (File)
Sun, Nov 3, 3:15 AM
Unknown Object (File)
Sun, Nov 3, 3:15 AM
Unknown Object (File)
Sun, Nov 3, 3:15 AM
Unknown Object (File)
Oct 12 2024, 11:13 AM
Unknown Object (File)
Sep 14 2024, 11:01 PM
Unknown Object (File)
Sep 14 2024, 11:01 PM
View All 51 Files
Subscribers
tomek

Details

Reviewers
ginsu
inka
Commits
rCOMM1f511853b7ad: [native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow
Summary

We'll be requiring a Farcaster account for the initial beta, so it makes sense to ask about it first.

Depends on D11972

Test Plan

Tested opening the registration flow from the main screen and from FullscreenSIWEPanel. Make sure ConnectFarcaster appears before ConnectEthereum. Make sure that I am able to successfully register

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 9 2024, 7:41 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 9 2024, 7:41 AM
ashoat added a child revision: D11974: [native] Make Farcaster required in new registration flow.May 9 2024, 7:56 AM
Harbormaster completed remote builds in B28811: Diff 40020.May 9 2024, 7:58 AM
ashoat requested review of this revision.May 9 2024, 7:58 AM
inka added a comment.May 9 2024, 8:26 AM

I think this is the test plan of the previous diff?

ginsu accepted this revision.May 9 2024, 12:12 PM

Accepting since code looks good + don't want to block, but might be worth to update test plan to better explain how this diff was tested

This revision is now accepted and ready to land.May 9 2024, 12:12 PM
ashoat edited the test plan for this revision. (Show Details)May 9 2024, 12:21 PM

Updated test plan

Closed by commit rCOMM1f511853b7ad: [native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow (authored by ashoat). · Explain WhyMay 9 2024, 1:10 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1f511853b7ad: [native] Swap order of ConnectEthereum and ConnectFarcaster in registration flow.

Revision Contents
Changeset List

Diff 40042

View Options

native/account/registration/account-does-not-exist.react.js

Loading...
View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/registration/connect-farcaster.react.js

Loading...
View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/registration-navigator.react.js

Loading...