[identity] Reduce log level for gRPC interceptors
ClosedPublic
Actions

Authored by bartek on May 10 2024, 3:39 AM.

Details

Reviewers

will

Commits

rCOMM7f97d6a03ba2: [identity] Reduce log level for gRPC interceptors

Summary

The auth and version interceptor logs are causes of terrible spam and it's difficult to find useful logs.
Reducing level to trace makes them distinguishable from others and allows to be disabled separately by using RUST_LOG=debug

Test Plan

Ran identity locally and some commtest tests to make some log spam.
Tested with RUST_LOG=identity=trace vs RUST_LOG=identity=debug

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 10 2024, 3:39 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 10 2024, 3:39 AM

Harbormaster completed remote builds in B28829: Diff 40064.May 10 2024, 3:54 AM

bartek published this revision for review.May 10 2024, 4:40 AM

will accepted this revision.May 10 2024, 7:36 AM

This revision is now accepted and ready to land.May 10 2024, 7:36 AM

Closed by commit rCOMM7f97d6a03ba2: [identity] Reduce log level for gRPC interceptors (authored by bartek). · Explain WhyMay 13 2024, 12:31 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7f97d6a03ba2: [identity] Reduce log level for gRPC interceptors.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

6 lines

shared.rs

6 lines

Diff 40064

View Options

services/identity/src/grpc_services/authenticated.rs