[native] Display meaningful alert if ExistingEthereumAccount login fails due to expired nonce
ClosedPublic
Actions

Authored by ashoat on May 12 2024, 7:33 PM.

Details

Reviewers

inka

Commits

rCOMMbbc83d98febe: [native] Display meaningful alert if ExistingEthereumAccount login fails due to…

Summary

This addresses part of ENG-7666, specifically for ExistingEthereumAccount. Doing this separately since it's the "easy part" and introduces some complicated navigation getParent() type parameterization that will be used in the next diff.

Would normally put @varun on the review here, but going to ask @inka instead because he is out.

Depends on D12008

Test Plan

I tested (or will test) this diff stack as follows:

Be in a multi-keyserver environment, testing SIWE with iOS simulator
Do a SIWE and then wait 2 minutes to let the nonce expire in the following screens:
- FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is disabled
- FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is enabled
- FullscreenSIWEPanel for an account that does exist
- New registration flow for an account that doesn't exist yet (RegistrationTerms)
- New registration flow for an account that does exist (ExistingEthereumAccount)
Make sure there are no duplicate Alerts, that in all cases an Alert is shown, and that the "back" action activates when the user confirms the Alert

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 12 2024, 7:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 12 2024, 7:33 PM

ashoat added a child revision: D12010: [native] Display meaningful alert if RegistrationTerms/FullscreenSIWEPanel login/registration fails due to expired nonce.May 12 2024, 7:34 PM

Harbormaster completed remote builds in B28861: Diff 40102.May 12 2024, 7:55 PM

ashoat requested review of this revision.May 12 2024, 7:55 PM

In the test plan you say

the "back" action activates when the user confirms the Alert

But from the code it looks like the user is navigated to main login screen upon accepting the alert. Is that right?

But from the code it looks like the user is navigated to main login screen upon accepting the alert. Is that right?

Yes, that's right. The "back" action is different for each of these interfaces, but the intention is to move the user back to somewhere where they can try again.

inka accepted this revision.May 13 2024, 6:53 AM

This revision is now accepted and ready to land.May 13 2024, 6:53 AM

Clear ethereumAccount from CachedUserSelections upon getting a nonce expiration error

Harbormaster completed remote builds in B28871: Diff 40124.May 13 2024, 10:26 AM

Closed by commit rCOMMbbc83d98febe: [native] Display meaningful alert if ExistingEthereumAccount login fails due to… (authored by ashoat). · Explain WhyMay 13 2024, 12:57 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbbc83d98febe: [native] Display meaningful alert if ExistingEthereumAccount login fails due to….