Details

Reviewers

Commits

rCOMM094480a836c0: Extract shared logci for SIWE panel state handling

Summary

The way ConnectEthereum and CreateSIWEBackupMessage handle SIWE panel state is exactly the same. Additionally getting signature for existing backup message will resuse this logic as well. Therefore this diff extracts it.

Test Plan

Test that SIWE registration, log in and backup message creation are unchanged.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.May 14 2024, 8:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 14 2024, 8:34 AM

marcin added a child revision: D12033: Introduce new header to siwe endpoint.May 14 2024, 8:39 AM

Harbormaster completed remote builds in B28898: Diff 40163.May 14 2024, 8:51 AM

marcin requested review of this revision.May 14 2024, 8:51 AM

Rebase master

Harbormaster completed remote builds in B29006: Diff 40315.May 17 2024, 12:52 AM

kamil accepted this revision.May 20 2024, 1:54 AM

kamil added inline comments.

native/account/siwe-hooks.js
159–165 ↗	(On Diff #40315)	thinking about adding `React.memo` here but probably we will not gain much

This revision is now accepted and ready to land.May 20 2024, 1:54 AM

ashoat added inline comments.May 20 2024, 6:53 AM

native/account/siwe-hooks.js
159–165 ↗	(On Diff #40315)	It's probably a good idea. Given the current usages (where we destructure right after calling) there is no advantage to it. But it's good practice, and somebody in the future might call `useSIWEPanelState` without destructuring immediately