Differential D12053

[web] Prevent AddKeyserverModal from resizing
ClosedPublic
Actions

Authored by ashoat on May 15 2024, 4:39 PM.

Details

Reviewers

ginsu

Commits

rCOMM87675fd73892: [web] Prevent AddKeyserverModal from resizing

Summary

This is an anti-pattern I have been harping on for over a year. We should never introduce an interface like this.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 15 2024, 4:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 15 2024, 4:39 PM

ashoat added a child revision: D12054: [web] Disable AddKeyserverModal button while keyserver check is in progress.May 15 2024, 4:44 PM

ashoat edited the test plan for this revision. (Show Details)May 15 2024, 4:51 PM

Harbormaster completed remote builds in B28949: Diff 40233.May 15 2024, 4:58 PM

ashoat requested review of this revision.May 15 2024, 4:58 PM

ginsu accepted this revision.May 15 2024, 6:03 PM

This revision is now accepted and ready to land.May 15 2024, 6:03 PM

Closed by commit rCOMM87675fd73892: [web] Prevent AddKeyserverModal from resizing. · Explain WhyMay 15 2024, 7:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM87675fd73892: [web] Prevent AddKeyserverModal from resizing.

Revision Contents
Changeset List

Path

Size

web/

modals/

keyserver-selection/

add-keyserver-modal.css

1 line

add-keyserver-modal.react.js

15 lines

Diff 40249

View Options

web/modals/keyserver-selection/add-keyserver-modal.css