Differential D12055

[native] Disable AddKeyserver button while keyserver check is in progress
ClosedPublic
Actions

Authored by ashoat on May 15 2024, 9:46 AM.

Details

Reviewers

Commits

rCOMM5a7e335edc3b: [native] Disable AddKeyserver button while keyserver check is in progress

Summary

We should never ever introduce an interface without considering loading state. This was a huge omission in the initial work on this project.

Depends on D12054

Test Plan

Added a sleep for this video:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 15 2024, 9:46 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 15 2024, 9:46 AM

ashoat added a child revision: D12056: [web] Factor out getVersionUnsupportedError.May 15 2024, 9:48 AM

ashoat edited the test plan for this revision. (Show Details)May 15 2024, 9:52 AM

Harbormaster completed remote builds in B28951: Diff 40235.May 15 2024, 10:02 AM

ashoat requested review of this revision.May 15 2024, 10:02 AM

ginsu accepted this revision.May 15 2024, 11:06 AM

This revision is now accepted and ready to land.May 15 2024, 11:06 AM

Closed by commit rCOMM5a7e335edc3b: [native] Disable AddKeyserver button while keyserver check is in progress (authored by ashoat). · Explain WhyMay 15 2024, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5a7e335edc3b: [native] Disable AddKeyserver button while keyserver check is in progress.

Revision Contents
Changeset List

Path

Size

native/

navigation/

header-right-text-button.react.js

13 lines

profile/

add-keyserver.react.js

27 lines

Diff 40250

View Options

native/navigation/header-right-text-button.react.js