[lib] Add httpMessageUserInfosHandler
ClosedPublic
Actions

Authored by inka on May 16 2024, 6:46 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM93732b264eeb: [lib] Add httpMessageUserInfosHandler

Summary

issue: ENG-7821
This function will be called on the result of fetch in callSingleKeyserverEndpoint
Responders return values which are validated on the keyserver side inside the responder functions created by createJSONResponder. The validated response is then returned to either:

handleAPIRequestClientSocketMessage in case of socket requests
jsonHandler in case of http requests

Following what those functions do with the result, we can tell what fields are being appended before being sent to the client. Those fields are: success, cookieChange, and in the case of an exception: error and payload.
But none of the fields have to be added. So we add those fields to the validator as optional

Test Plan

Tested with the next diff - called this function on the result of fetch and checked that user ids are correctly extracted from respones

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 16 2024, 6:46 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 16 2024, 6:46 AM

inka added a parent revision: D12052: [lib] Extract user ids from server socket messages.May 16 2024, 7:03 AM

inka added a child revision: D12073: [lib] Use httpMessageUserInfosHandler.

Harbormaster completed remote builds in B28981: Diff 40285.May 16 2024, 7:05 AM

inka requested review of this revision.May 16 2024, 7:06 AM

ashoat added inline comments.May 16 2024, 11:53 AM

lib/handlers/http-message-user-infos-handler.js
31 ↗	(On Diff #40285)	I think this could have a better name... maybe `extractAndPersistUserInfosFromMessages`?

tomek accepted this revision.May 17 2024, 6:08 AM

tomek added inline comments.

lib/handlers/http-message-user-infos-handler.js
18–20 ↗	(On Diff #40285)	Are all these fields mandatory? I can see that e.g. `RegisterResponse` doesn't have `cookieInvalidated` flag.
35–37 ↗	(On Diff #40285)	Should we memoize the validators?
40 ↗	(On Diff #40285)	We will need to figure out how to get the `dispatch` function. We can't use hooks here.