Page MenuHomePhabricator

[identity] fix origin validation logic
ClosedPublic

Authored by varun on May 20 2024, 3:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 4:06 AM
Unknown Object (File)
Sun, Jun 23, 4:18 AM
Unknown Object (File)
Sun, Jun 23, 4:18 AM
Unknown Object (File)
Sun, Jun 23, 4:16 AM
Unknown Object (File)
Sat, Jun 22, 2:46 AM
Unknown Object (File)
Sat, Jun 22, 12:59 AM
Unknown Object (File)
Fri, Jun 21, 10:56 PM
Unknown Object (File)
Fri, Jun 21, 9:59 PM
Subscribers

Details

Summary

on prod, we should not require a port in the allow origin list. https://web.comm.app should work.

Test Plan

there's no good way to test this on prod currently.

added unit test to make sure "https://web.comm.app" origin works. this should unblock release.

To test if grpc-web works on prod, @bartek suggested that we silently add some Ping calls in the next web release and just see if they fail or not

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable