[lib] Skip Tunnelbroker QR auth message if decryption fails
ClosedPublic
Actions

Authored by bartek on May 20 2024, 4:07 AM.

Details

Reviewers

ashoat

Commits

rCOMM208ac24a6f14: [lib] Skip Tunnelbroker QR auth message if decryption fails

Summary

Continuation ENG-8131.
We should skip Tunnelbroker messages that cannot be decrypted.

Depends on D12104

Test Plan

Repeated repro steps from Linear

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 20 2024, 4:07 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMay 20 2024, 4:07 AM

Harbormaster completed remote builds in B29054: Diff 40391.May 20 2024, 4:45 AM

bartek published this revision for review.May 20 2024, 5:26 AM

ashoat accepted this revision.May 20 2024, 5:51 AM

ashoat added inline comments.

lib/components/qr-auth-handler.react.js
117 ↗	(On Diff #40391)	Can we add a `console.log` or `console.error` or something of the thrown exception?

This revision is now accepted and ready to land.May 20 2024, 5:51 AM

bartek added inline comments.May 20 2024, 6:13 AM

lib/components/qr-auth-handler.react.js
117 ↗	(On Diff #40391)	Yeah, `console.warn` should be okay

Add console.warn

This revision was landed with ongoing or failed builds.May 20 2024, 6:24 AM

Closed by commit rCOMM208ac24a6f14: [lib] Skip Tunnelbroker QR auth message if decryption fails (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM208ac24a6f14: [lib] Skip Tunnelbroker QR auth message if decryption fails.

Harbormaster completed remote builds in B29061: Diff 40400.May 20 2024, 6:36 AM

Revision Contents
Changeset List

Path

Size

lib/

components/

qr-auth-handler.react.js

9 lines

Diff 40402

View Options

lib/components/qr-auth-handler.react.js

[lib] Skip Tunnelbroker QR auth message if decryption failsClosedPublicActions