Page MenuHomePhabricator

[native] Fix error propagation in AESCryptoModule
ClosedPublic

Authored by bartek on May 20 2024, 1:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 1:17 AM
Unknown Object (File)
Mon, Jun 24, 4:37 AM
Unknown Object (File)
Sun, Jun 23, 4:18 AM
Unknown Object (File)
Sun, Jun 23, 4:18 AM
Unknown Object (File)
Sun, Jun 23, 4:18 AM
Unknown Object (File)
Sun, Jun 23, 4:16 AM
Unknown Object (File)
Thu, Jun 20, 7:01 AM
Unknown Object (File)
Wed, Jun 19, 6:15 PM
Subscribers

Details

Summary

ENG-8131.
The try! disabled error propagation to JS so the app crashes when decryption fails

Test Plan
let key = new Uint8Array(16);
let data = new Uint8Array(12+16+5);
let buffer = new Uint8Array(10); // too small
try {
  AESCryptoModule.decrypt(key, data, buffer);
} catch (err) {
  // got InvalidDataLengthException from AESCryptoModule.swift L175
  console.log(err);
}

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable