Paths

Table of Contentst

Differential D12232

[lib] Pass userStateBeforeRecovery to setNewSession call in resolveKeyserverSessionInvalidation
ClosedPublic
Actions

Authored by ashoat on May 28 2024, 10:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 12:54 PM

	Unknown Object (File)
	Tue, Nov 12, 9:41 AM

	Unknown Object (File)
	Tue, Nov 12, 9:41 AM

	Unknown Object (File)
	Tue, Nov 12, 9:03 AM

	Unknown Object (File)
	Tue, Nov 5, 2:26 PM

	Unknown Object (File)
	Sun, Nov 3, 5:08 PM

	Unknown Object (File)
	Thu, Oct 31, 4:40 PM

	Unknown Object (File)
	Oct 10 2024, 9:51 PM

View All 51 Files

Subscribers

None

Details

Reviewers

inka
tomek

Commits

rCOMMa2a2d84a9b90: [lib] Pass userStateBeforeRecovery to setNewSession call in…

Summary

This resolves ENG-8244. This was an oversight... we should be passing userStateBeforeRecovery to setNewSession here in order to avoid triggering invalidSessionRecovery.

Test Plan

Log in a test user in a multi-keyserver environment
Delete the user's cookie in MariaDB
Background and foreground the app
Confirm that we no longer trigger a loop of the error mentioned in the Linear task

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 28 2024, 10:17 AM

ashoat added a child revision: D12233: [lib] Avoid passing userStateBeforeRecovery to invalidateKeyserverSession.

Harbormaster completed remote builds in B29272: Diff 40730.May 28 2024, 10:34 AM

ashoat requested review of this revision.May 28 2024, 10:34 AM

tomek accepted this revision.May 29 2024, 1:38 AM

This revision is now accepted and ready to land.May 29 2024, 1:38 AM

Closed by commit rCOMMa2a2d84a9b90: [lib] Pass userStateBeforeRecovery to setNewSession call in… (authored by ashoat). · Explain WhyMay 29 2024, 10:08 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa2a2d84a9b90: [lib] Pass userStateBeforeRecovery to setNewSession call in….

Revision Contents
Changeset List

Path

Size

lib/

keyserver-conn/

recovery-utils.js

4 lines

Diff 40756

lib/keyserver-conn/recovery-utils.js

Loading...