Page MenuHomePhabricator
Differential D12232

[lib] Pass userStateBeforeRecovery to setNewSession call in resolveKeyserverSessionInvalidation
ClosedPublic
Actions

Authored by ashoat on May 28 2024, 10:17 AM.
Tags
None
Referenced Files
F5519206: D12232.id40756.diff
Fri, Apr 11, 2:09 PM
Unknown Object (File)
Thu, Apr 10, 10:28 PM
Unknown Object (File)
Thu, Apr 10, 7:21 PM
Unknown Object (File)
Thu, Apr 10, 4:27 AM
Unknown Object (File)
Sun, Apr 6, 8:30 AM
Unknown Object (File)
Thu, Mar 13, 10:32 AM
Unknown Object (File)
Feb 28 2025, 3:02 PM
Unknown Object (File)
Feb 28 2025, 3:02 PM
View All 75 Files
Subscribers
None

Details

Reviewers
inka
tomek
Commits
rCOMMa2a2d84a9b90: [lib] Pass userStateBeforeRecovery to setNewSession call in…
Summary

This resolves ENG-8244. This was an oversight... we should be passing userStateBeforeRecovery to setNewSession here in order to avoid triggering invalidSessionRecovery.

Test Plan
  1. Log in a test user in a multi-keyserver environment
  2. Delete the user's cookie in MariaDB
  3. Background and foreground the app
  4. Confirm that we no longer trigger a loop of the error mentioned in the Linear task

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
keyserver-conn/
4 lines

Diff 40730

View Options

lib/keyserver-conn/recovery-utils.js

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines