Page MenuHomePhabricator

[native] Fix LoggedOutModal buttons not appearing on load in release build
ClosedPublic

Authored by ashoat on May 29 2024, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 12:26 AM
Unknown Object (File)
Sat, Nov 2, 6:48 PM
Unknown Object (File)
Mon, Oct 28, 6:47 AM
Unknown Object (File)
Wed, Oct 23, 6:08 PM
Unknown Object (File)
Fri, Oct 18, 5:24 AM
Unknown Object (File)
Fri, Oct 18, 4:25 AM
Unknown Object (File)
Sat, Oct 12, 7:14 AM
Unknown Object (File)
Sat, Oct 12, 2:35 AM
Subscribers

Details

Summary

This resolves ENG-8321.

I made a mistake in D12208. In Reanimated 3 it's okay to pass a Reanimated value directly to a style prop of an Animated.View, but not in Reanimated 2. I had been reading the Reanimated 3 docs initially, and after learning about this I updated most places but seem to have missed this spot.

In Reanimated 2, all uses of Reanimated values must be wrapped in useAnimatedStyle.

Guessing it only shows up in a release build due to some race conditions.

Test Plan

Confirmed that it resolves the linked Linear issue by compiling a release build to my iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable