Page MenuHomePhabricator
Differential D12244

[native] Fix LoggedOutModal buttons not appearing on load in release build
ClosedPublic
Actions

Authored by ashoat on May 29 2024, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 1:41 PM
Unknown Object (File)
Tue, Apr 15, 3:48 AM
Unknown Object (File)
Mon, Apr 14, 11:09 PM
Unknown Object (File)
Sun, Apr 13, 7:36 PM
Unknown Object (File)
Tue, Apr 8, 4:26 PM
Unknown Object (File)
Wed, Apr 2, 1:00 PM
Unknown Object (File)
Fri, Mar 28, 9:08 PM
Unknown Object (File)
Feb 27 2025, 11:26 PM
View All Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMMf8ee46466872: [native] Fix LoggedOutModal buttons not appearing on load in release build
Summary

This resolves ENG-8321.

I made a mistake in D12208. In Reanimated 3 it's okay to pass a Reanimated value directly to a style prop of an Animated.View, but not in Reanimated 2. I had been reading the Reanimated 3 docs initially, and after learning about this I updated most places but seem to have missed this spot.

In Reanimated 2, all uses of Reanimated values must be wrapped in useAnimatedStyle.

Guessing it only shows up in a release build due to some race conditions.

Test Plan

Confirmed that it resolves the linked Linear issue by compiling a release build to my iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
7 lines

Diff 40775

View Options

native/account/logged-out-modal.react.js

Show All 15 Linesimport {
type ClientRequestsServerSocketMessage, type ClientRequestsServerSocketMessage,
type ClientServerSocketMessage, type ClientServerSocketMessage,
clientSocketMessageTypes, clientSocketMessageTypes,
serverSocketMessageTypes, serverSocketMessageTypes,
type ClientSocketMessageWithoutID, type ClientSocketMessageWithoutID,
type SocketListener, type SocketListener,
type ConnectionInfo, type ConnectionInfo,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { authoritativeKeyserverID } from '../utils/authoritative-keyserver.js';
import { ServerError, SocketTimeout } from '../utils/errors.js'; import { ServerError, SocketTimeout } from '../utils/errors.js';
import { useSelector, useDispatch } from '../utils/redux-utils.js'; import { useSelector, useDispatch } from '../utils/redux-utils.js';
type BaseProps = { type BaseProps = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
+sendMessage: (message: ClientSocketMessageWithoutID) => number, +sendMessage: (message: ClientSocketMessageWithoutID) => number,
+addListener: (listener: SocketListener) => void, +addListener: (listener: SocketListener) => void,
+removeListener: (listener: SocketListener) => void, +removeListener: (listener: SocketListener) => void,
▲ Show 20 Lines • Show All 103 Lines • ▼ Show 20 Lines try {
); );
} }
} }
} }
} }
const ConnectedRequestResponseHandler: React.ComponentType<BaseProps> = const ConnectedRequestResponseHandler: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedRequestResponseHandler(props) { React.memo<BaseProps>(function ConnectedRequestResponseHandler(props) {
const connection = useSelector( const connection = useSelector(connectionSelector(props.keyserverID));
connectionSelector(authoritativeKeyserverID()),
);
invariant(connection, 'keyserver missing from keyserverStore'); invariant(connection, 'keyserver missing from keyserverStore');
const dispatch = useDispatch(); const dispatch = useDispatch();
return ( return (
<RequestResponseHandler <RequestResponseHandler
{...props} {...props}
connection={connection} connection={connection}
dispatch={dispatch} dispatch={dispatch}
/> />
); );
}); });
export default ConnectedRequestResponseHandler; export default ConnectedRequestResponseHandler;