Page MenuHomePhabricator

[native] Fix LoggedOutModal buttons not appearing on load in release build
ClosedPublic

Authored by ashoat on May 29 2024, 7:52 PM.
Tags
None
Referenced Files
F2835882: D12244.diff
Sat, Sep 28, 3:05 PM
Unknown Object (File)
Thu, Sep 26, 5:57 PM
Unknown Object (File)
Sun, Sep 15, 5:12 AM
Unknown Object (File)
Sat, Sep 14, 11:23 AM
Unknown Object (File)
Mon, Sep 9, 8:51 AM
Unknown Object (File)
Mon, Sep 9, 6:03 AM
Unknown Object (File)
Mon, Sep 9, 5:22 AM
Unknown Object (File)
Mon, Sep 9, 4:38 AM
Subscribers

Details

Summary

This resolves ENG-8321.

I made a mistake in D12208. In Reanimated 3 it's okay to pass a Reanimated value directly to a style prop of an Animated.View, but not in Reanimated 2. I had been reading the Reanimated 3 docs initially, and after learning about this I updated most places but seem to have missed this spot.

In Reanimated 2, all uses of Reanimated values must be wrapped in useAnimatedStyle.

Guessing it only shows up in a release build due to some race conditions.

Test Plan

Confirmed that it resolves the linked Linear issue by compiling a release build to my iOS simulator

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/reanimated
Lint
No Lint Coverage
Unit
No Test Coverage