Nice and clean! Most of changes here are to update types.
Depends on D12256
Details
Details
Played around on my local simulator and confirmed that the animation works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/calendar
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/calendar/calendar-input-bar.react.js | ||
|---|---|---|
| 18–21 ↗ | (On Diff #40807) | Noticed this wasn't memoized for some reason |
| native/flow-typed/npm/react-native-reanimated_v2.x.x.js | ||
| 49–51 ↗ | (On Diff #40807) | I matched these to what we have in native/types/styles.js |
| 370 ↗ | (On Diff #40807) | Noticed this wasn't read-only for some reason |
Comment Actions
Noticed that we weren't wrapping BaseBuilderAnimationConfig with $ReadOnly, despite it including a spread of BaseLayoutAnimationConfig
Updated all types in the react-native-reanimated libdef that have spreads of other types to be wrapped with $ReadOnly