[blob] Don't check if the invite link is reserved
ClosedPublic
Actions

Authored by tomek on Jun 3 2024, 5:39 AM.

Details

Reviewers

bartek
varun

Commits

rCOMMfda12f9dcff2: [blob] Don't check if the invite link is reserved

Summary

We're checking this only on the keyserver side for now.

https://linear.app/comm/issue/ENG-8302/stop-checking-if-an-invite-link-contains-a-reserved-username-on-blob

Test Plan

Run a local blob service, comment out reserved link check on a keyserver. Create a reserved link, open it and verify that the blob was downloaded using the browser inspector. Also check if offensive links check still works on keyserver.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jun 3 2024, 5:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 3 2024, 5:39 AM

Harbormaster completed remote builds in B29362: Diff 40847.Jun 3 2024, 5:54 AM

tomek requested review of this revision.Jun 3 2024, 5:54 AM

bartek accepted this revision.Jun 3 2024, 6:39 AM

This revision is now accepted and ready to land.Jun 3 2024, 6:39 AM

Closed by commit rCOMMfda12f9dcff2: [blob] Don't check if the invite link is reserved (authored by tomek). · Explain WhyJun 3 2024, 6:44 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMfda12f9dcff2: [blob] Don't check if the invite link is reserved.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

service.rs

4 lines

Diff 40856

View Options

services/blob/src/service.rs

[blob] Don't check if the invite link is reservedClosedPublicActions