Page MenuHomePhabricator
Differential D12316

[web] Open a community when a user clicks an invite link and is already a member
ClosedPublic
Actions

Authored by tomek on Jun 5 2024, 3:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 11:33 PM
Unknown Object (File)
Wed, Feb 26, 8:41 AM
Unknown Object (File)
Feb 13 2025, 12:48 PM
Unknown Object (File)
Jan 24 2025, 9:46 PM
Unknown Object (File)
Jan 20 2025, 12:20 AM
Unknown Object (File)
Jan 19 2025, 10:28 PM
Unknown Object (File)
Jan 19 2025, 10:28 PM
Unknown Object (File)
Jan 19 2025, 10:27 PM
View All Files
Subscribers
ashoat

Details

Reviewers
inka
ginsu
Commits
rCOMMfb63d1e6ca6c: [web] Open a community when a user clicks an invite link and is already a member
Summary

Check if a user is already a member and navigate to a thread.

https://linear.app/comm/issue/ENG-8162/open-a-community-when-a-user-clicks-a-link-and-is-already-a-member

Test Plan

Click a link to a community where a user is a member - check if a modal is displayed and after closing it a proper thread is displayed.
Click a link to a community where a user isn't a member - the old experience should be shown.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
invite-links/
33 lines

Diff 41065

View Options

web/invite-links/invite-link-handler.react.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines