Page MenuHomePhabricator

[native] add autoCapitalize="none"
ClosedPublic

Authored by varun on Jun 10 2024, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 4:53 PM
Unknown Object (File)
Sat, Nov 30, 3:27 PM
Unknown Object (File)
Sat, Nov 30, 1:28 PM
Unknown Object (File)
Fri, Nov 29, 5:53 PM
Unknown Object (File)
Fri, Nov 29, 12:58 PM
Unknown Object (File)
Wed, Nov 27, 8:15 AM
Unknown Object (File)
Tue, Nov 12, 4:55 PM
Unknown Object (File)
Tue, Nov 12, 4:46 PM
Subscribers

Details

Summary

we want this on all password inputs

Test Plan

checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context

no regression when running android emulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Jun 10 2024, 1:33 PM

I'd frame the test plan as something like "checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context"

Test plan should be thought of as "how I know this change is safe"

This revision is now accepted and ready to land.Jun 10 2024, 1:43 PM
varun edited the test plan for this revision. (Show Details)
varun added 1 blocking reviewer(s): ashoat.

update test plan

This revision now requires review to proceed.Jun 10 2024, 1:58 PM

messed up test plan update

This revision is now accepted and ready to land.Jun 10 2024, 2:01 PM
This revision was landed with ongoing or failed builds.Jun 10 2024, 2:05 PM
This revision was automatically updated to reflect the committed changes.