Page MenuHomePhabricator

[native] add autoCapitalize="none"
ClosedPublic

Authored by varun on Mon, Jun 10, 1:09 PM.
Tags
None
Referenced Files
F2030794: D12385.id41193.diff
Tue, Jun 18, 12:15 AM
F2030793: D12385.id41181.diff
Tue, Jun 18, 12:15 AM
F2030792: D12385.id41180.diff
Tue, Jun 18, 12:15 AM
F2030791: D12385.id41175.diff
Tue, Jun 18, 12:15 AM
F2026531: D12385.diff
Mon, Jun 17, 5:05 PM
Unknown Object (File)
Thu, Jun 13, 4:40 PM
Unknown Object (File)
Mon, Jun 10, 6:44 PM
Unknown Object (File)
Mon, Jun 10, 6:24 PM
Subscribers

Details

Summary

we want this on all password inputs

Test Plan

checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context

no regression when running android emulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Mon, Jun 10, 1:33 PM

I'd frame the test plan as something like "checked code and confirmed that other password TextInputs have this property. checked docs and it should be safe in this context"

Test plan should be thought of as "how I know this change is safe"

This revision is now accepted and ready to land.Mon, Jun 10, 1:43 PM
varun edited the test plan for this revision. (Show Details)
varun added 1 blocking reviewer(s): ashoat.

update test plan

This revision now requires review to proceed.Mon, Jun 10, 1:58 PM

messed up test plan update

This revision is now accepted and ready to land.Mon, Jun 10, 2:01 PM
This revision was landed with ongoing or failed builds.Mon, Jun 10, 2:05 PM
This revision was automatically updated to reflect the committed changes.