Page MenuHomePhabricator
Differential D12447

[identity][websocket] Call DB client directly to verify CSAT
ClosedPublic
Actions

Authored by bartek on Mon, Jun 17, 3:30 AM.
Tags
None
Referenced Files
F2113978: D12447.id41378.diff
Wed, Jun 26, 4:49 AM
F2108610: D12447.id41380.diff
Tue, Jun 25, 1:33 PM
Unknown Object (File)
Tue, Jun 25, 9:38 AM
Unknown Object (File)
Mon, Jun 24, 11:37 PM
Unknown Object (File)
Mon, Jun 24, 6:16 PM
Unknown Object (File)
Sun, Jun 23, 11:12 AM
Unknown Object (File)
Sun, Jun 23, 11:09 AM
Unknown Object (File)
Sat, Jun 22, 8:23 PM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
varun
Commits
rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT
Summary

Noticed that we're doing an unnecessary round-trip with search WebSocket auth:
Identity WS, when received auth message, connected to itself via gRPC just to verify CSAT.

Replaced this with a direct DDB call.

Test Plan

Verified that identity search is still working on local clients (with local Identity).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Jun 17, 3:30 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jun 17, 3:30 AM
Harbormaster completed remote builds in B29709: Diff 41378.Mon, Jun 17, 3:46 AM
bartek published this revision for review.Mon, Jun 17, 4:22 AM
will accepted this revision.Tue, Jun 18, 7:15 AM

This makes a lot of sense. Not sure why I didn't consider this on first implementation but glad you caught it now.

This revision is now accepted and ready to land.Tue, Jun 18, 7:15 AM
Closed by commit rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT (authored by bartek). · Explain WhyWed, Jun 19, 2:23 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
4 lines
websockets/
95 lines
12 lines

Diff 41482

View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/websockets/auth.rs

Loading...
View Options

services/identity/src/websockets/mod.rs

Loading...