Page MenuHomePhabricator
Differential D12583

[landing] introduce download page
ClosedPublic
Actions

Authored by ginsu on Thu, Jun 27, 1:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 7:28 PM
Unknown Object (File)
Thu, Jul 4, 10:40 AM
Unknown Object (File)
Wed, Jul 3, 9:43 PM
Unknown Object (File)
Wed, Jul 3, 8:06 PM
Unknown Object (File)
Wed, Jul 3, 2:17 PM
Unknown Object (File)
Wed, Jul 3, 2:17 PM
Unknown Object (File)
Mon, Jul 1, 3:42 PM
Unknown Object (File)
Sat, Jun 29, 9:12 PM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMb73cf51e75c8: [landing] introduce download page
Summary

This diff introduces the download page where a user can press the button of the platform they are using to download the app on to their device.

I based the UI off of this low fidelity prototype, but very open to feedback/changing any of the copy and/or UI

Screenshot 2024-05-16 at 12.51.50 PM.png (1×2 px, 139 KB)

Linear task: https://linear.app/comm/issue/ENG-8009/add-download-links-for-all-platforms-to-landing-page

Test Plan

Please see the screenshots below

desktop:

Screenshot 2024-06-27 at 4.08.38 AM.png (2×3 px, 723 KB)

tablet:

Screenshot 2024-06-27 at 4.09.36 AM.png (2×3 px, 938 KB)

mobile:

Screenshot 2024-06-27 at 4.09.55 AM.png (2×3 px, 934 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Thu, Jun 27, 1:05 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 1:05 AM
ginsu edited the summary of this revision. (Show Details)Thu, Jun 27, 1:10 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu attached a referenced file: F2125519: Screenshot 2024-06-27 at 4.09.55 AM.png. (Show Details)
ginsu attached a referenced file: F2125517: Screenshot 2024-06-27 at 4.09.36 AM.png. (Show Details)
ginsu attached a referenced file: F2125515: Screenshot 2024-06-27 at 4.08.38 AM.png. (Show Details)
Harbormaster completed remote builds in B29948: Diff 41745.Thu, Jun 27, 1:21 AM
ginsu requested review of this revision.Thu, Jun 27, 1:21 AM
ginsu added a child revision: D12591: [landing] add link to download page in the header.Thu, Jun 27, 10:23 AM
ashoat accepted this revision.Mon, Jul 1, 11:56 AM

Nice!!

landing/download.react.js
53 ↗(On Diff #41745)

Can we replace this with "Note that account creation is only possible on mobile."

72 ↗(On Diff #41745)

Can we have this link to https://electron-update.commtechnologies.org/download/dmg

78 ↗(On Diff #41745)

Can we have this link to https://electron-update.commtechnologies.org/download/windows

This revision is now accepted and ready to land.Mon, Jul 1, 11:56 AM
ginsu updated this revision to Diff 41855.Mon, Jul 1, 12:26 PM
ginsu edited the test plan for this revision. (Show Details)

address comments

This revision was landed with ongoing or failed builds.Mon, Jul 1, 12:31 PM
Closed by commit rCOMMb73cf51e75c8: [landing] introduce download page (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb73cf51e75c8: [landing] introduce download page.
Harbormaster failed remote builds in B30031: Diff 41855!Mon, Jul 1, 12:35 PM

Revision Contents
Changeset List

PathSize
landing/
37 lines
96 lines

Diff 41858

View Options

landing/download.css

Loading...
View Options

landing/download.react.js

Loading...