[lib] Fix accidental variable naming from D12495
ClosedPublic
Actions

Authored by ashoat on Jul 3 2024, 7:58 PM.

Details

Reviewers

tomek
marcin
inka

Commits

rCOMM1b3dff868ac3: [lib] Fix accidental variable naming from D12495

Summary

In D12495, I accidentally named these variables test, which isn't a very good variable name.

The new one might be a bit verbose but I figured it's better than test.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 3 2024, 7:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:12 PM

Harbormaster failed remote builds in B30109: Diff 41980!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 3 2024, 8:33 PM

Harbormaster failed remote builds in B30115: Diff 41986!

Rebase

Harbormaster completed remote builds in B30119: Diff 41990.Jul 3 2024, 9:10 PM

ashoat requested review of this revision.Jul 3 2024, 9:10 PM

inka accepted this revision.Jul 4 2024, 7:02 AM

This revision is now accepted and ready to land.Jul 4 2024, 7:02 AM

Closed by commit rCOMM1b3dff868ac3: [lib] Fix accidental variable naming from D12495 (authored by ashoat). · Explain WhyJul 4 2024, 11:15 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1b3dff868ac3: [lib] Fix accidental variable naming from D12495.

Revision Contents
Changeset List

Path

Size

lib/

shared/

redux/

legacy-update-roles-and-permissions.js

12 lines

Diff 42064

View Options

lib/shared/redux/legacy-update-roles-and-permissions.js

[lib] Fix accidental variable naming from D12495ClosedPublicActions