Paths

Table of Contentst

[Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 5:53 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types

Summary

ENG-8621.

This improves readability, we can distingiush direction of message sender and recipient.

Test Plan

This only changes types, should not affect logic or content of messages sent between device <-> Tunnelbroker so only yarn flow:all and cargo check.

Diff Detail

Repository

rCOMM Comm

Branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 5:53 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 5:53 AM

kamil edited the summary of this revision. (Show Details)Jul 23 2024, 5:57 AM

kamil removed a parent revision: D12841: [Tunnelbroker] implement Web Push config.

kamil published this revision for review.Jul 23 2024, 6:20 AM

kamil added a child revision: D12857: [lib] remove unused Tunnelbroker message validators.Jul 23 2024, 6:20 AM

tomek accepted this revision.Jul 24 2024, 6:03 AM

tomek added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
300	Are you sure this is the right type? Shouldn't be `deviceToTunnelbroker`?

This revision is now accepted and ready to land.Jul 24 2024, 6:03 AM

use deviceToTunnelbroker

Harbormaster completed remote builds in B30662: Diff 42762.Jul 25 2024, 2:10 AM

Closed by commit rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types (authored by kamil). · Explain WhyJul 25 2024, 2:54 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

tunnelbroker.js

33 lines

lib/

components/

qr-auth-provider.react.js

8 lines

tunnelbroker/

peer-to-peer-message-handler.js

11 lines

tunnelbroker-context.js

27 lines

types/

tunnelbroker/

messages.js

68 lines

native/

profile/

secondary-device-qr-code-scanner.react.js

9 lines

tunnelbroker-menu.react.js

10 lines

services/

commtest/

src/

tunnelbroker/

socket.rs

10 lines

tunnelbroker/

src/

websockets/

session.rs

33 lines

shared/

tunnelbroker_messages/

src/

messages/

mod.rs

26 lines

web/

settings/

tunnelbroker-message-list.react.js

14 lines

Diff 42686

View Options

keyserver/src/socket/tunnelbroker.js

View Options

lib/components/qr-auth-provider.react.js

View Options

lib/tunnelbroker/peer-to-peer-message-handler.js

View Options

lib/tunnelbroker/tunnelbroker-context.js

View Options

lib/types/tunnelbroker/messages.js

View Options

native/profile/secondary-device-qr-code-scanner.react.js

View Options

native/profile/tunnelbroker-menu.react.js

View Options

services/commtest/src/tunnelbroker/socket.rs

View Options

services/tunnelbroker/src/websockets/session.rs

View Options

shared/tunnelbroker_messages/src/messages/mod.rs

View Options

web/settings/tunnelbroker-message-list.react.js

[Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42686

keyserver/src/socket/tunnelbroker.js

lib/components/qr-auth-provider.react.js

lib/tunnelbroker/peer-to-peer-message-handler.js

lib/tunnelbroker/tunnelbroker-context.js

lib/types/tunnelbroker/messages.js

native/profile/secondary-device-qr-code-scanner.react.js

native/profile/tunnelbroker-menu.react.js

services/commtest/src/tunnelbroker/socket.rs

services/tunnelbroker/src/websockets/session.rs

shared/tunnelbroker_messages/src/messages/mod.rs

web/settings/tunnelbroker-message-list.react.js

[Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types
ClosedPublic
Actions

Revision Contents
Changeset List