[lib] improve naming in Tunnelbroker socket
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 6:45 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM8a4d98aa506b: [lib] improve naming in Tunnelbroker socket

Summary

ENG-8621.

sendMessage -> sendMessageToDevice: this method is used with TunnelbrokerClientMessageToDevice prop which is device specific, alternatively this can be sendMessageToPeer
sendMessageToDeviceRequest -> sendMessage: this is a generic method interacting with raw socket and promise abstraction, alternatively sendMessageRequest

Depends on D12857

Test Plan

Just rename, yarn flow:all

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 6:45 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 6:45 AM

kamil added a child revision: D12859: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`.Jul 23 2024, 7:06 AM

kamil published this revision for review.Jul 23 2024, 7:06 AM

Harbormaster completed remote builds in B30609: Diff 42695.Jul 23 2024, 7:07 AM

tomek accepted this revision.Jul 24 2024, 6:24 AM

tomek added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
324 ↗	(On Diff #42695)	Sounds quite strange to have a plural name as the argument type
lib/types/tunnelbroker/messages.js
71 ↗	(On Diff #42695)
web/settings/account-settings.react.js
94 ↗	(On Diff #42695)	Should we also rename this prop?