Paths

Table of Contentst

[Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 2:06 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->…

Summary

ENG-8621.
ENG-8609

After we launched CSAT we can rename only static type to not break older clients.

Depends on D12858

Test Plan

Flow and Tunnelbroker integration tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 2:06 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 2:06 PM

Harbormaster completed remote builds in B30610: Diff 42697.Jul 23 2024, 2:25 PM

kamil published this revision for review.Jul 25 2024, 8:45 AM

tomek accepted this revision.Jul 25 2024, 1:28 PM

tomek added inline comments.

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs
37–38 ↗	(On Diff #42697)	Might be worth testing it.

This revision is now accepted and ready to land.Jul 25 2024, 1:28 PM

use rename and test with device

Harbormaster failed remote builds in B30685: Diff 42797!Jul 26 2024, 9:26 AM

Harbormaster completed remote builds in B30685: Diff 42797.Jul 26 2024, 9:38 AM

Closed by commit rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->…. · Explain WhyJul 26 2024, 9:39 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

tunnelbroker.js

4 lines

lib/

tunnelbroker/

tunnelbroker-context.js

4 lines

types/

tunnelbroker/

	device-to-tunnelbroker-request-status-types.js
	message-to-device-request-status-types.js

6 lines

message-to-device-request-status-types.js

messages.js

10 lines

services/

commtest/

src/

tunnelbroker/

socket.rs

6 lines

tests/

tunnelbroker_sender_confirmation_tests.rs

8 lines

tunnelbroker/

src/

websockets/

mod.rs

8 lines

shared/

tunnelbroker_messages/

src/

messages/

message_to_device_request_status.rs

26 lines

mod.rs

2 lines

Diff 42798

View Options

keyserver/src/socket/tunnelbroker.js

View Options

lib/tunnelbroker/tunnelbroker-context.js

View Options

lib/types/tunnelbroker/device-to-tunnelbroker-request-status-types.js

View Options

lib/types/tunnelbroker/message-to-device-request-status-types.js

View Options

lib/types/tunnelbroker/messages.js

View Options

services/commtest/src/tunnelbroker/socket.rs

View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

View Options

services/tunnelbroker/src/websockets/mod.rs

View Options

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs

View Options

shared/tunnelbroker_messages/src/messages/mod.rs

[Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42798

keyserver/src/socket/tunnelbroker.js

lib/tunnelbroker/tunnelbroker-context.js

lib/types/tunnelbroker/device-to-tunnelbroker-request-status-types.js

lib/types/tunnelbroker/message-to-device-request-status-types.js

lib/types/tunnelbroker/messages.js

services/commtest/src/tunnelbroker/socket.rs

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

services/tunnelbroker/src/websockets/mod.rs

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs

shared/tunnelbroker_messages/src/messages/mod.rs

[Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`
ClosedPublic
Actions

Revision Contents
Changeset List