Page MenuHomePhabricator
Differential D12967

[lib] Remove community from thick threads
ClosedPublic
Actions

Authored by tomek on Aug 5 2024, 3:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 5:06 PM
Unknown Object (File)
Sat, Feb 22, 3:03 PM
Unknown Object (File)
Feb 18 2025, 4:51 AM
Unknown Object (File)
Feb 18 2025, 4:51 AM
Unknown Object (File)
Feb 18 2025, 4:51 AM
Unknown Object (File)
Feb 18 2025, 4:50 AM
Unknown Object (File)
Feb 1 2025, 2:51 AM
Unknown Object (File)
Jan 29 2025, 1:26 PM
View All 75 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMdf3698446e2f: [lib] Remove community from thick threads
Summary

Thick threads can't have a community.

https://linear.app/comm/issue/ENG-8937/remove-community-from-mutablethickrawthreadinfo

More context D12914.

Test Plan

Made sure that it's possible to create a sidebar. Also checked if persisting and reading thin and thick threads from SQLite works on web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 5 2024, 3:24 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 3:24 AM
tomek added inline comments.Aug 5 2024, 3:27 AM
lib/utils/thread-ops-utils.js
47 ↗(On Diff #43067)

This is for Flow. ClientDBThreadInfo has community as a mandatory nullable property, but thick threads don't have it at all.

native/redux/persist.js
405–427 ↗(On Diff #43067)

We shouldn't expect any thick thread to be in the store while performing this old migration.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 3:45 AM
Harbormaster failed remote builds in B30887: Diff 43067!
tomek added a child revision: D12969: [lib] Rename editor to joiner in join thread operation.Aug 5 2024, 3:53 AM
Harbormaster completed remote builds in B30887: Diff 43067.Aug 5 2024, 4:17 AM
tomek requested review of this revision.Aug 5 2024, 4:17 AM
tomek edited the summary of this revision. (Show Details)Aug 5 2024, 6:20 AM
tomek edited the summary of this revision. (Show Details)
inka accepted this revision.Aug 5 2024, 6:23 AM
This revision is now accepted and ready to land.Aug 5 2024, 6:23 AM
Closed by commit rCOMMdf3698446e2f: [lib] Remove community from thick threads (authored by tomek). · Explain WhyAug 6 2024, 3:35 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMdf3698446e2f: [lib] Remove community from thick threads.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
1 line
types/
2 lines
1 line
utils/
2 lines
native/
redux/
10 lines

Diff 43168

View Options

lib/shared/dm-ops/create-thread-spec.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/utils/thread-ops-utils.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

native/redux/persist.js

Loading...