Implement notificationsCreationData for send-reaction-message-spec
AbandonedPublic
Actions

Authored by marcin on Aug 8 2024, 4:04 AM.

Details

Reviewers

kamil
tomek
ashoat

Summary

This differential implements notificationsCreationData for reaction-message-spec

Test Plan

Apply this small patch: https://gist.github.com/marcinwasowicz/d8a0f08110384e3f740b7cf367136b37
Send text message
Ensure that recipient is seeing notification informing about heart reaction

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-8237

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 8 2024, 4:04 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 4:04 AM

marcin added a parent revision: D13023: Implement notificationsCreationData for chante-thread-settings-spec.Aug 8 2024, 4:04 AM

marcin retitled this revision from Implement notificationsCreationData for send-reaction=message-spec to Implement notificationsCreationData for send-reaction-message-spec.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 8 2024, 4:27 AM

Harbormaster failed remote builds in B31005: Diff 43254!

marcin requested review of this revision.Aug 8 2024, 5:05 AM

ashoat added inline comments.Aug 8 2024, 6:09 AM

lib/shared/dm-ops/send-reaction-message-spec.js
87–97	Code duplication – let's see if we can reduce it. See comments in parent diffs

ashoat requested changes to this revision.Aug 8 2024, 7:26 AM

This revision now requires changes to proceed.Aug 8 2024, 7:26 AM

marcin abandoned this revision.Aug 20 2024, 7:30 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

send-reaction-message-spec.js

20 lines

Diff 43254

View Options

lib/shared/dm-ops/send-reaction-message-spec.js

	use commtest::identity::device::{			use commtest::identity::device::{
	create_device, DEVICE_TYPE, PLACEHOLDER_CODE_VERSION,			register_user_device, DEVICE_TYPE, PLACEHOLDER_CODE_VERSION,
	};			};
	use commtest::service_addr;			use commtest::service_addr;
	use grpc_clients::identity::{			use grpc_clients::identity::{
	get_unauthenticated_client, protos::unauth::VerifyUserAccessTokenRequest,			get_unauthenticated_client, protos::unauth::VerifyUserAccessTokenRequest,
	};			};

	#[tokio::test]			#[tokio::test]
	async fn verify_access_token() {			async fn verify_access_token() {
	let identity_grpc_endpoint = service_addr::IDENTITY_GRPC.to_string();			let identity_grpc_endpoint = service_addr::IDENTITY_GRPC.to_string();
	let device_info = create_device(None).await;			let device_info = register_user_device(None, None).await;

	let mut identity_client = get_unauthenticated_client(			let mut identity_client = get_unauthenticated_client(
	&identity_grpc_endpoint,			&identity_grpc_endpoint,
	PLACEHOLDER_CODE_VERSION,			PLACEHOLDER_CODE_VERSION,
	DEVICE_TYPE.to_string(),			DEVICE_TYPE.to_string(),
	)			)
	.await			.await
	.expect("Couldn't connect to identity service");			.expect("Couldn't connect to identity service");
	Show All 14 Lines

Implement notificationsCreationData for send-reaction-message-specAbandonedPublicActions