Implement notificationsCreationData for send-reaction-message-spec
AbandonedPublic
Actions

Authored by marcin on Aug 8 2024, 4:04 AM.

Details

Reviewers

kamil
tomek
ashoat

Summary

This differential implements notificationsCreationData for reaction-message-spec

Test Plan

Apply this small patch: https://gist.github.com/marcinwasowicz/d8a0f08110384e3f740b7cf367136b37
Send text message
Ensure that recipient is seeing notification informing about heart reaction

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-8237

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 8 2024, 4:04 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 4:04 AM

marcin added a parent revision: D13023: Implement notificationsCreationData for chante-thread-settings-spec.Aug 8 2024, 4:04 AM

marcin retitled this revision from Implement notificationsCreationData for send-reaction=message-spec to Implement notificationsCreationData for send-reaction-message-spec.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 8 2024, 4:27 AM

Harbormaster failed remote builds in B31005: Diff 43254!

marcin requested review of this revision.Aug 8 2024, 5:05 AM

ashoat added inline comments.Aug 8 2024, 6:09 AM