This addresses ENG-9015.
Details
Details
- Reviewers
bartek - Commits
- rCOMMd1e1d81a3992: [native] Fix encrypted media upload on Android
Confirm that upload of .dat files on Android no longer triggers the following error:
'upload failed', [Error: Failed to upload blob: guessContentTypeFromName(file.name) must not be null], undefined, undefined
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
An alternate solution would potentially be to alter the file extension that the encryption logic uses for these files, either on Android or globally. I don't have a strong preference
| native/input/input-state-container.react.js | ||
|---|---|---|
| 1241–1249 ↗ | (On Diff #43292) | I guess we could always add mimeType: 'application/octet-stream' to uploadOptions and skip that platform check. But this is also okay |
| native/input/input-state-container.react.js | ||
|---|---|---|
| 1241–1249 ↗ | (On Diff #43292) | I think that would probably be better, but I'd rather not have to test it on iOS right now. Going to land as-is |