Page MenuHomePhabricator

[lib] Don't check relyingOnAuthoritativeKeyserver when reducing removePeerUsersActionType
ClosedPublic

Authored by ashoat on Aug 10 2024, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:58 PM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:24 AM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Subscribers

Details

Summary

There was some ambiguous feedback in D12962@bartek interpreted that this check should be left, but I interpreted that it should be removed.

My intuition is that we should reduce UserStore and AuxUserStore under the same conditions. Curious for other reviewers' take.

Test Plan

I haven't tested this. If reviewers think it needs to be tested, I would appreciate @bartek's help on that, as he wrote the initial diff and has context on how to test

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

In my review, I meant that this check should be removed

My intuition is that we should reduce UserStore and AuxUserStore under the same conditions. Curious for other reviewers' take.

Agree with that

This revision is now accepted and ready to land.Aug 12 2024, 8:02 AM