Differential D13044

[native] Select logout flow basing on being primary device
ClosedPublic
Actions

Authored by bartek on Aug 11 2024, 3:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 12:17 AM

	Unknown Object (File)
	Sat, Nov 9, 10:02 PM

	Unknown Object (File)
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 12:23 PM

	Unknown Object (File)
	Tue, Oct 22, 1:16 PM

	Unknown Object (File)
	Tue, Oct 22, 9:14 AM

	Unknown Object (File)
	Tue, Oct 22, 8:32 AM

	Unknown Object (File)
	Sep 25 2024, 4:12 PM

View All 48 Files

Subscribers

Details

Reviewers

kamil
varun
ashoat

Commits

rCOMM093bf14a19e2: [native] Select logout flow basing on being primary device

Summary

Address ENG-8550.

Merged two dev "new flow logout" buttons into one
Added new selector to get primary device

Test Plan

Created a user, logged in on two mobile devices
Confirmed that pressing the button on secondary logs out only itself (secondary device logout)
Confirmed that pressing the button on the primary logs out both (primary device logout)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 11 2024, 3:19 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 11 2024, 3:19 AM

Harbormaster failed remote builds in B31035: Diff 43296!Aug 11 2024, 3:46 AM

bartek published this revision for review.Aug 12 2024, 12:09 AM

I need to be set as a blocking reviewer for any diff with copy. Please remember this going forward.

ashoat accepted this revision.Aug 12 2024, 6:54 AM

ashoat added inline comments.

native/profile/profile-screen.react.js
392 ↗	(On Diff #43296)	Let's change this to "Log out all devices?" Please include the question mark
393 ↗	(On Diff #43296)	Let's change this to: This device is your primary device, so logging out will cause all of your other devices to log out too.
396–397 ↗	(On Diff #43296)

This revision is now accepted and ready to land.Aug 12 2024, 6:54 AM

Address feedback

Harbormaster completed remote builds in B31131: Diff 43439.Aug 19 2024, 2:46 AM

Closed by commit rCOMM093bf14a19e2: [native] Select logout flow basing on being primary device (authored by bartek). · Explain WhyAug 19 2024, 4:42 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM093bf14a19e2: [native] Select logout flow basing on being primary device.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

user-selectors.js

10 lines

native/

profile/

profile-screen.react.js

86 lines

Diff 43445

lib/selectors/user-selectors.js

Loading...

native/profile/profile-screen.react.js

Loading...