Page MenuHomePhabricator
Differential D13058

[lib] Delete old replies count logic
ClosedPublic
Actions

Authored by tomek on Aug 13 2024, 5:44 AM.
Tags
None
Referenced Files
F5179206: D13058.id.diff
Fri, Apr 4, 2:58 PM
Unknown Object (File)
Fri, Apr 4, 9:52 AM
Unknown Object (File)
Fri, Apr 4, 8:39 AM
Unknown Object (File)
Fri, Apr 4, 12:57 AM
Unknown Object (File)
Thu, Apr 3, 3:17 AM
Unknown Object (File)
Mon, Mar 31, 5:23 PM
Unknown Object (File)
Tue, Mar 11, 3:05 PM
Unknown Object (File)
Mar 6 2025, 7:21 AM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM26695fb50339: [lib] Delete old replies count logic
Summary

In the next diff we're introducing a more unified approach.

https://linear.app/comm/issue/ENG-8930/unify-the-approach-to-replies-count-and-unread-status-updates

Depends on D13057

Test Plan

Flow.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 13 2024, 5:44 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 5:44 AM
tomek added a child revision: D13059: [lib] Update the replies count.Aug 13 2024, 5:44 AM
tomek edited the summary of this revision. (Show Details)Aug 13 2024, 5:46 AM
tomek added a parent revision: D13057: [lib] Add function allowing extracting ThreadInfo from updates.
tomek retitled this revision from [lib] Delete the replies to [lib] Delete old replies count logic.Aug 13 2024, 5:48 AM
Harbormaster completed remote builds in B31059: Diff 43337.Aug 13 2024, 6:00 AM
tomek requested review of this revision.Aug 13 2024, 6:00 AM
inka accepted this revision.Aug 19 2024, 6:20 AM
This revision is now accepted and ready to land.Aug 19 2024, 6:20 AM
tomek updated this revision to Diff 43514.Aug 20 2024, 8:15 AM

Rebase

Harbormaster completed remote builds in B31180: Diff 43514.Aug 20 2024, 8:33 AM
Closed by commit rCOMM26695fb50339: [lib] Delete old replies count logic (authored by tomek). · Explain WhyAug 20 2024, 9:34 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM26695fb50339: [lib] Delete old replies count logic.

Revision Contents
Changeset List

Diff 43522

View Options

lib/shared/dm-ops/add-members-spec.js

Show First 20 Lines • Show All 1,077 Lines • ▼ Show 20 Lines memberInfo:
| ServerMemberInfo, | ServerMemberInfo,
): boolean { ): boolean {
if (memberInfo.minimallyEncoded) { if (memberInfo.minimallyEncoded) {
return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE); return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE);
} }
return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value; return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value;
} }
function roleIsDefaultRole(
roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo,
): boolean {
return !!(roleInfo && roleInfo.isDefault);
}
function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean { function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean {
return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins'); return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins');
} }
function threadHasAdminRole( function threadHasAdminRole(
threadInfo: ?( threadInfo: ?(
| LegacyRawThreadInfo | LegacyRawThreadInfo
| RawThreadInfo | RawThreadInfo
▲ Show 20 Lines • Show All 746 Lines • ▼ Show 20 Linesexport {
getMinimallyEncodedCurrentUser, getMinimallyEncodedCurrentUser,
threadFrozenDueToBlock, threadFrozenDueToBlock,
threadFrozenDueToViewerBlock, threadFrozenDueToViewerBlock,
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
threadUIName, threadUIName,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadTypeDescriptions, threadTypeDescriptions,
memberHasAdminPowers, memberHasAdminPowers,
roleIsDefaultRole,
roleIsAdminRole, roleIsAdminRole,
threadHasAdminRole, threadHasAdminRole,
identifyInvalidatedThreads, identifyInvalidatedThreads,
permissionsDisabledByBlock, permissionsDisabledByBlock,
emptyItemText, emptyItemText,
threadNoun, threadNoun,
threadLabel, threadLabel,
useWatchThread, useWatchThread,
Show All 24 Lines
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Show First 20 Lines • Show All 1,077 Lines • ▼ Show 20 Lines memberInfo:
| ServerMemberInfo, | ServerMemberInfo,
): boolean { ): boolean {
if (memberInfo.minimallyEncoded) { if (memberInfo.minimallyEncoded) {
return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE); return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE);
} }
return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value; return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value;
} }
function roleIsDefaultRole(
roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo,
): boolean {
return !!(roleInfo && roleInfo.isDefault);
}
function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean { function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean {
return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins'); return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins');
} }
function threadHasAdminRole( function threadHasAdminRole(
threadInfo: ?( threadInfo: ?(
| LegacyRawThreadInfo | LegacyRawThreadInfo
| RawThreadInfo | RawThreadInfo
▲ Show 20 Lines • Show All 746 Lines • ▼ Show 20 Linesexport {
getMinimallyEncodedCurrentUser, getMinimallyEncodedCurrentUser,
threadFrozenDueToBlock, threadFrozenDueToBlock,
threadFrozenDueToViewerBlock, threadFrozenDueToViewerBlock,
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
threadUIName, threadUIName,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadTypeDescriptions, threadTypeDescriptions,
memberHasAdminPowers, memberHasAdminPowers,
roleIsDefaultRole,
roleIsAdminRole, roleIsAdminRole,
threadHasAdminRole, threadHasAdminRole,
identifyInvalidatedThreads, identifyInvalidatedThreads,
permissionsDisabledByBlock, permissionsDisabledByBlock,
emptyItemText, emptyItemText,
threadNoun, threadNoun,
threadLabel, threadLabel,
useWatchThread, useWatchThread,
Show All 24 Lines
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show First 20 Lines • Show All 1,077 Lines • ▼ Show 20 Lines memberInfo:
| ServerMemberInfo, | ServerMemberInfo,
): boolean { ): boolean {
if (memberInfo.minimallyEncoded) { if (memberInfo.minimallyEncoded) {
return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE); return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE);
} }
return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value; return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value;
} }
function roleIsDefaultRole(
roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo,
): boolean {
return !!(roleInfo && roleInfo.isDefault);
}
function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean { function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean {
return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins'); return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins');
} }
function threadHasAdminRole( function threadHasAdminRole(
threadInfo: ?( threadInfo: ?(
| LegacyRawThreadInfo | LegacyRawThreadInfo
| RawThreadInfo | RawThreadInfo
▲ Show 20 Lines • Show All 746 Lines • ▼ Show 20 Linesexport {
getMinimallyEncodedCurrentUser, getMinimallyEncodedCurrentUser,
threadFrozenDueToBlock, threadFrozenDueToBlock,
threadFrozenDueToViewerBlock, threadFrozenDueToViewerBlock,
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
threadUIName, threadUIName,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadTypeDescriptions, threadTypeDescriptions,
memberHasAdminPowers, memberHasAdminPowers,
roleIsDefaultRole,
roleIsAdminRole, roleIsAdminRole,
threadHasAdminRole, threadHasAdminRole,
identifyInvalidatedThreads, identifyInvalidatedThreads,
permissionsDisabledByBlock, permissionsDisabledByBlock,
emptyItemText, emptyItemText,
threadNoun, threadNoun,
threadLabel, threadLabel,
useWatchThread, useWatchThread,
Show All 24 Lines
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Show First 20 Lines • Show All 1,077 Lines • ▼ Show 20 Lines memberInfo:
| ServerMemberInfo, | ServerMemberInfo,
): boolean { ): boolean {
if (memberInfo.minimallyEncoded) { if (memberInfo.minimallyEncoded) {
return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE); return hasPermission(memberInfo.permissions, threadPermissions.CHANGE_ROLE);
} }
return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value; return !!memberInfo.permissions[threadPermissions.CHANGE_ROLE]?.value;
} }
function roleIsDefaultRole(
roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo,
): boolean {
return !!(roleInfo && roleInfo.isDefault);
}
function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean { function roleIsAdminRole(roleInfo: ?ClientLegacyRoleInfo | ?RoleInfo): boolean {
return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins'); return !!(roleInfo && !roleInfo.isDefault && roleInfo.name === 'Admins');
} }
function threadHasAdminRole( function threadHasAdminRole(
threadInfo: ?( threadInfo: ?(
| LegacyRawThreadInfo | LegacyRawThreadInfo
| RawThreadInfo | RawThreadInfo
▲ Show 20 Lines • Show All 746 Lines • ▼ Show 20 Linesexport {
getMinimallyEncodedCurrentUser, getMinimallyEncodedCurrentUser,
threadFrozenDueToBlock, threadFrozenDueToBlock,
threadFrozenDueToViewerBlock, threadFrozenDueToViewerBlock,
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
threadUIName, threadUIName,
threadInfoFromRawThreadInfo, threadInfoFromRawThreadInfo,
threadTypeDescriptions, threadTypeDescriptions,
memberHasAdminPowers, memberHasAdminPowers,
roleIsDefaultRole,
roleIsAdminRole, roleIsAdminRole,
threadHasAdminRole, threadHasAdminRole,
identifyInvalidatedThreads, identifyInvalidatedThreads,
permissionsDisabledByBlock, permissionsDisabledByBlock,
emptyItemText, emptyItemText,
threadNoun, threadNoun,
threadLabel, threadLabel,
useWatchThread, useWatchThread,
Show All 24 Lines
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...