Page MenuHomePhabricator

Re-throw all exceptions except from race condition between workers
ClosedPublic

Authored by marcin on Aug 19 2024, 10:34 AM.
Tags
None
Referenced Files
F2842700: D13116.diff
Sun, Sep 29, 3:19 PM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Fri, Sep 20, 5:07 AM
Unknown Object (File)
Mon, Sep 16, 1:12 AM
Subscribers
None

Details

Summary

This differntial modifies localforage to provide method to get message of exception that is thrown when race condition occurs. Additionally this method is used innotifs code to filter exception and decide when to silence and when to re-throw exception.

Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/4aaa7ecc71af0e91c66cf96e748161c0
  2. Uncomment the first change. Youd should be seeing logs in shared worker console but no errors being thrown.
  3. Comment the first change and uncomment the second. You should be seeing errors thrown in web app console.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9025-new
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
patches/localforage+1.10.0.patch
330

not sure what is the best, but previous was confusing

This revision is now accepted and ready to land.Aug 20 2024, 1:38 AM