Page MenuHomePhabricator

[lib] Make FarcasterDataHandler go through useFindUserIdentities
ClosedPublic

Authored by ashoat on Aug 19 2024, 2:02 PM.
Tags
None
Referenced Files
F3384936: D13117.diff
Thu, Nov 28, 10:42 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:01 PM
Unknown Object (File)
Oct 19 2024, 2:32 PM
Unknown Object (File)
Oct 18 2024, 8:59 PM
Unknown Object (File)
Oct 18 2024, 3:25 PM
Unknown Object (File)
Oct 18 2024, 3:25 PM
Subscribers

Details

Summary

There are currently two components that call findUserIdentities: UserInfosHandler and FarcasterDataHandler.

The former goes through useFindUserIdentities, but the latter accesses findUserIdentities directly via the IdentityClientContext context.

This diff makes both of them go through useFindUserIdentities, as preparation for adding a caching layer to that hook.

This is the first step to addressing ENG-9002.

Test Plan

This is a simple refactor. I made sure that IdentityClientContext should always be set where FarcasterDataHandler is rendered on both native and web.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/userinfos
Lint
No Lint Coverage
Unit
No Test Coverage