Page MenuHomePhabricator
Differential D13126

[lib] Introduce UserIdentityCache
ClosedPublic
Actions

Authored by ashoat on Aug 20 2024, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 6 2025, 12:41 PM
Unknown Object (File)
Mar 5 2025, 8:40 AM
Unknown Object (File)
Mar 5 2025, 3:48 AM
Unknown Object (File)
Mar 5 2025, 3:48 AM
Unknown Object (File)
Mar 5 2025, 3:47 AM
Unknown Object (File)
Mar 5 2025, 3:47 AM
Unknown Object (File)
Jan 13 2025, 6:15 AM
Unknown Object (File)
Jan 2 2025, 6:06 AM
View All 46 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMMa7dbca2fd1be: [lib] Introduce UserIdentityCache
Summary

This is modelled after ENSCache and FCCache, but it's implemented as a React component since it needs access to a React context.

This addresses part of ENG-9002.

Depends on D13117

Test Plan

I deployed a release build to my iOS device with some logging inside both IdentityServiceContentProvider and UserInfosHandler. I confirmed that the latter only ever queried for users once, even though the latter queried multiple times

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/userinfos
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
actions/
7 lines
components/
247 lines
native/
149 lines
web/
19 lines

Diff 43527

View Options

lib/actions/user-actions.js

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

lib/components/user-identity-cache.react.js

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

native/root.react.js

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines
View Options

web/root.js

Show First 20 Lines • Show All 902 Lines • ▼ Show 20 Lines rawThreadInfo = {
pinnedCount: serverThreadInfo.pinnedCount, pinnedCount: serverThreadInfo.pinnedCount,
}; };
} }
return shouldMinimallyEncodePermissions return shouldMinimallyEncodePermissions
? minimallyEncodeRawThreadInfo(rawThreadInfo) ? minimallyEncodeRawThreadInfo(rawThreadInfo)
: rawThreadInfo; : rawThreadInfo;
} }
function threadUIName( function threadUIName(threadInfo: ThreadInfo): string | ThreadEntity {
threadInfo: LegacyThreadInfo | ThreadInfo,
): string | ThreadEntity {
if (threadInfo.name) { if (threadInfo.name) {
return firstLine(threadInfo.name); return firstLine(threadInfo.name);
} }
let threadMembers: $ReadOnlyArray<RelativeMemberInfo>; const threadMembers: $ReadOnlyArray<RelativeMemberInfo> =
let memberEntities: $ReadOnlyArray<UserEntity>; threadInfo.members.filter(memberInfo => memberInfo.role);
// Branching below is to appease flow const memberEntities: $ReadOnlyArray<UserEntity> = threadMembers.map(member =>
if (threadInfo.minimallyEncoded) { ET.user({ userInfo: member }),
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role); );
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
} else {
threadMembers = threadInfo.members.filter(memberInfo => memberInfo.role);
memberEntities = threadMembers.map(member => ET.user({ userInfo: member }));
}
return { return {
type: 'thread', type: 'thread',
id: threadInfo.id, id: threadInfo.id,
name: threadInfo.name, name: threadInfo.name,
display: 'uiName', display: 'uiName',
uiName: memberEntities, uiName: memberEntities,
ifJustViewer: ifJustViewer:
▲ Show 20 Lines • Show All 1,024 Lines • Show Last 20 Lines