Page MenuHomePhabricator
Differential D13139

[lib] address feedback from D13098
ClosedPublic
Actions

Authored by varun on Aug 22 2024, 10:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2025, 4:13 AM
Unknown Object (File)
Mar 15 2025, 4:13 AM
Unknown Object (File)
Mar 15 2025, 4:12 AM
Unknown Object (File)
Mar 5 2025, 7:55 AM
Unknown Object (File)
Feb 16 2025, 1:45 PM
Unknown Object (File)
Feb 12 2025, 8:10 PM
Unknown Object (File)
Feb 12 2025, 8:10 PM
Unknown Object (File)
Feb 12 2025, 8:10 PM
View All 53 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMMec66fa63d98a: [lib] address feedback from D13098
Summary

accidentally landed D13098 without addressing a piece of feedback.

Test Plan

tested this change with rest of original stack to make sure cache worked as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
6 lines

Diff 43623

View Options

lib/utils/fc-cache.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines