[lib] address feedback from D13098
ClosedPublic
Actions

Authored by varun on Aug 22 2024, 10:07 AM.

Tags

None

Referenced Files

	F3188653: D13139.id43623.diff
	Fri, Nov 8, 7:02 PM

	F3188652: D13139.id43590.diff
	Fri, Nov 8, 7:02 PM

	F3188596: D13139.diff
	Fri, Nov 8, 7:01 PM

	Unknown Object (File)
	Fri, Nov 8, 2:29 AM

	Unknown Object (File)
	Sun, Oct 20, 8:05 AM

	Unknown Object (File)
	Sun, Oct 13, 12:27 PM

	Unknown Object (File)
	Sun, Oct 13, 11:19 AM

	Unknown Object (File)
	Sep 25 2024, 1:30 AM

View All 35 Files

Subscribers

tomek

Details

Reviewers

ashoat

Commits

rCOMMec66fa63d98a: [lib] address feedback from D13098

Summary

accidentally landed D13098 without addressing a piece of feedback.

Test Plan

tested this change with rest of original stack to make sure cache worked as expected

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 22 2024, 10:07 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 22 2024, 10:07 AM

varun mentioned this in D13098: [lib] modify FC cache to store username and pfp url.Aug 22 2024, 10:08 AM

Harbormaster completed remote builds in B31219: Diff 43590.Aug 22 2024, 10:28 AM

varun requested review of this revision.Aug 22 2024, 10:28 AM

ashoat accepted this revision.Aug 22 2024, 4:00 PM

This revision is now accepted and ready to land.Aug 22 2024, 4:00 PM

Closed by commit rCOMMec66fa63d98a: [lib] address feedback from D13098 (authored by varun). · Explain WhyAug 23 2024, 9:50 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMec66fa63d98a: [lib] address feedback from D13098.

Revision Contents
Changeset List

Path

Size

lib/

utils/

fc-cache.js

6 lines

Diff 43590

View Options

[lib] address feedback from D13098ClosedPublicActions