Page MenuHomePhabricator
Differential D13098

[lib] modify FC cache to store username and pfp url
ClosedPublic
Actions

Authored by varun on Aug 15 2024, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 15, 6:26 AM
Unknown Object (File)
Fri, Sep 6, 10:42 AM
Unknown Object (File)
Fri, Sep 6, 9:54 AM
Unknown Object (File)
Wed, Sep 4, 12:47 PM
Unknown Object (File)
Tue, Sep 3, 11:40 PM
Unknown Object (File)
Mon, Sep 2, 5:57 PM
Unknown Object (File)
Fri, Aug 30, 11:00 PM
Unknown Object (File)
Fri, Aug 30, 8:47 AM
View All 29 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMMbd07096b3e65: [lib] modify FC cache to store username and pfp url
Summary

Depends on D13097

Test Plan

tested later in stack by successfully setting avatar from farcaster

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Aug 15 2024, 10:52 PM
varun held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:52 PM
varun added a child revision: D13099: [lib] add getFCAvatarURLs method to NeynarClientProvider.Aug 15 2024, 10:53 PM
Harbormaster completed remote builds in B31122: Diff 43419.Aug 15 2024, 11:09 PM
varun published this revision for review.Aug 19 2024, 7:18 AM
varun added inline comments.
lib/utils/fc-cache.js
144 ↗(On Diff #43419)

wasn't sure about this line

varun edited the test plan for this revision. (Show Details)Aug 19 2024, 7:35 AM
varun added reviewers: ashoat, tomek.
ashoat accepted this revision.Tue, Aug 20, 12:33 PM
ashoat added inline comments.
lib/utils/fc-cache.js
144 ↗(On Diff #43419)

JavaScript is weird... this condition will let null through because typeof null === 'object'

To be fully consistent with the prior implementation, you should add || farcasterUser === null here (although not clear how important that is)

This revision is now accepted and ready to land.Tue, Aug 20, 12:33 PM
ashoat added inline comments.Tue, Aug 20, 1:49 PM
lib/utils/fc-cache.js
144 ↗(On Diff #43419)

Actually I'd just add || !farcasterUser rather than || farcasterUser === null

Closed by commit rCOMMbd07096b3e65: [lib] modify FC cache to store username and pfp url (authored by varun). · Explain WhyThu, Aug 22, 10:04 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMbd07096b3e65: [lib] modify FC cache to store username and pfp url.
varun mentioned this in D13139: [lib] address feedback from D13098.Thu, Aug 22, 10:07 AM
varun added inline comments.Thu, Aug 22, 10:08 AM
lib/utils/fc-cache.js
144 ↗(On Diff #43419)

my change addressing this feedback wasn't picked up for some reason so i created D13139

varun mentioned this in rCOMMec66fa63d98a: [lib] address feedback from D13098.Fri, Aug 23, 9:50 AM
ashoat mentioned this in D13101: [native] let user choose farcaster avatar.Wed, Sep 18, 12:09 PM

Revision Contents
Changeset List

PathSize
lib/
hooks/
6 lines
utils/
6 lines
59 lines

Diff 43589

View Options

lib/hooks/fc-cache.js

Loading...
View Options

lib/utils/farcaster-helpers.js

Loading...
View Options

lib/utils/fc-cache.js

Loading...