[lib] add getFCAvatarURLs method to NeynarClientProvider
AcceptedPublic
Actions

Authored by varun on Aug 15 2024, 10:53 PM.

Details

Reviewers

ashoat
tomek

Summary

Based this off the existing client provider method for FC usernames

Deduping made this code harder to follow. That said, I can revise this if reviewers think it would be better anyway

Depends on D13098

Test Plan

tested at end of stack by successfully fetching farcaster avatar URL with neynar

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 15 2024, 10:53 PM

varun held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:53 PM

varun added a child revision: D13100: [native] add farcaster avatar URL to registration workflow.Aug 15 2024, 10:53 PM

Harbormaster completed remote builds in B31123: Diff 43420.Aug 15 2024, 11:16 PM

rebase

varun edited the summary of this revision. (Show Details)Fri, Sep 6, 12:59 PM

varun edited the test plan for this revision. (Show Details)

varun edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B31469: Diff 43947.Fri, Sep 6, 1:19 PM

varun published this revision for review.Wed, Sep 18, 6:43 AM

varun added reviewers: ashoat, tomek.

rebase

Harbormaster completed remote builds in B31694: Diff 44306.Wed, Sep 18, 7:29 AM

ashoat accepted this revision.Wed, Sep 18, 9:10 AM

This revision is now accepted and ready to land.Wed, Sep 18, 9:10 AM

ashoat mentioned this in D13100: [native] add farcaster avatar URL to registration workflow.Wed, Sep 18, 11:48 AM

Revision Contents
Changeset List

Path

Size

lib/

components/

neynar-client-provider.react.js

7 lines

utils/

farcaster-helpers.js

71 lines

Diff 44306

View Options

lib/components/neynar-client-provider.react.js